You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@spamassassin.apache.org on 2022/05/30 13:21:08 UTC
[Bug 7999] New: Plugins DCC.pm, FreeMail.pm, Phishing.pm, URIDetail.pm: return undef after got_hit/rule_ready
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7999
Bug ID: 7999
Summary: Plugins DCC.pm, FreeMail.pm, Phishing.pm,
URIDetail.pm: return undef after got_hit/rule_ready
Product: Spamassassin
Version: 4.0.0
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P2
Component: Plugins
Assignee: dev@spamassassin.apache.org
Reporter: sa-mst@lrz.de
Target Milestone: Undefined
After an explicit call to got_hit or rule_ready the return value should be
undef instead of 1 or 0, otherwise another implicit call to got_hit or
rule_ready would be triggered, which is superfluous.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7999] Plugins DCC.pm, FreeMail.pm, Phishing.pm, URIDetail.pm: return undef after got_hit/rule_ready
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7999
Sidney Markowitz <si...@sidney.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sidney@sidney.com
--- Comment #2 from Sidney Markowitz <si...@sidney.com> ---
(In reply to Michael Storz from comment #1)
> Created attachment 5785 [details]
Hi Michael, could you please submit an ICLA if you are going to submit patches?
I expect that Henrik is in a better position to look at and evaluate the patch
itself, but I'm handling the bureaucratic details required by ASF of making
sure that all submitted code comes from someone who has filed an ICLA.
See https://www.apache.org/licenses/contributor-agreements.html
Thanks
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7999] Plugins DCC.pm, FreeMail.pm, Phishing.pm, URIDetail.pm: return undef after got_hit/rule_ready
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7999
Henrik Krohns <ap...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |apache@hege.li
--- Comment #3 from Henrik Krohns <ap...@hege.li> ---
"superfluous" is completely correct, as this would be no blocker for 4.0.0 or
make any difference how things work.
Likely some of these can be even rewritten for better logic, as FreeMail etc is
not even async, there is no point returning undef anyway.
I'll take this just as a hint on what to work on, so this should require no
ICLA as I'm not applying it.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7999] Plugins DCC.pm, FreeMail.pm, Phishing.pm, URIDetail.pm: return undef after got_hit/rule_ready
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7999
Michael Storz <sa...@lrz.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sa-mst@lrz.de
--- Comment #1 from Michael Storz <sa...@lrz.de> ---
Created attachment 5785
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5785&action=edit
return undef after call to got_hit/rule_ready
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7999] Plugins DCC.pm, FreeMail.pm, Phishing.pm, URIDetail.pm: return undef after got_hit/rule_ready
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7999
Henrik Krohns <ap...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #4 from Henrik Krohns <ap...@hege.li> ---
Revision 1901578
Revision 1901579
Revision 1901581
--
You are receiving this mail because:
You are the assignee for the bug.