You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2014/11/03 10:31:18 UTC

git commit: WICKET-5729 Avoid using input names that conflict with JavaScript DOM API method and attribute names

Repository: wicket
Updated Branches:
  refs/heads/master b60ec64d0 -> dd1d6c6c5


WICKET-5729 Avoid using input names that conflict with JavaScript DOM API method and attribute names

Fix the selectors in the Gym.js tests


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/dd1d6c6c
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/dd1d6c6c
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/dd1d6c6c

Branch: refs/heads/master
Commit: dd1d6c6c5b82f917505b9b889912cd4523b93e1a
Parents: b60ec64
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Mon Nov 3 11:30:29 2014 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Mon Nov 3 11:30:29 2014 +0200

----------------------------------------------------------------------
 wicket-examples/src/main/webapp/js-test/tests/ajax/form.js         | 2 +-
 .../src/main/webapp/js-test/tests/bean-validation/name.js          | 2 +-
 wicket-examples/src/main/webapp/js-test/tests/mailtemplate.js      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/dd1d6c6c/wicket-examples/src/main/webapp/js-test/tests/ajax/form.js
----------------------------------------------------------------------
diff --git a/wicket-examples/src/main/webapp/js-test/tests/ajax/form.js b/wicket-examples/src/main/webapp/js-test/tests/ajax/form.js
index 7c3059f..8082e7f 100644
--- a/wicket-examples/src/main/webapp/js-test/tests/ajax/form.js
+++ b/wicket-examples/src/main/webapp/js-test/tests/ajax/form.js
@@ -29,7 +29,7 @@ $q(document).ready(function() {
 		gym.load('/ajax/form').then(function($) {
 
 			// enter just the name field
-			var $nameInput = $('input[name=name]');
+			var $nameInput = $('input[name="p::name"]');
 			var name = 'Ajax form name';
 			$nameInput.val(name);
 

http://git-wip-us.apache.org/repos/asf/wicket/blob/dd1d6c6c/wicket-examples/src/main/webapp/js-test/tests/bean-validation/name.js
----------------------------------------------------------------------
diff --git a/wicket-examples/src/main/webapp/js-test/tests/bean-validation/name.js b/wicket-examples/src/main/webapp/js-test/tests/bean-validation/name.js
index ee9eb0d..5647fb0 100644
--- a/wicket-examples/src/main/webapp/js-test/tests/bean-validation/name.js
+++ b/wicket-examples/src/main/webapp/js-test/tests/bean-validation/name.js
@@ -22,7 +22,7 @@ $q(document).ready(function() {
 	"use strict";
 
 	var selectors = {
-		nameInput: "input[name=name]",
+		nameInput: "input[name='p::name']",
 		nameNullErrorFeedback: "li.feedbackPanelERROR > span:contains(\"'Name' is required\")",
 		nameRangeErrorFeedback: "li.feedbackPanelERROR > span:contains(\"'Name' length must be between 2 and 30\")"
 

http://git-wip-us.apache.org/repos/asf/wicket/blob/dd1d6c6c/wicket-examples/src/main/webapp/js-test/tests/mailtemplate.js
----------------------------------------------------------------------
diff --git a/wicket-examples/src/main/webapp/js-test/tests/mailtemplate.js b/wicket-examples/src/main/webapp/js-test/tests/mailtemplate.js
index ac9318c..6847f6f 100644
--- a/wicket-examples/src/main/webapp/js-test/tests/mailtemplate.js
+++ b/wicket-examples/src/main/webapp/js-test/tests/mailtemplate.js
@@ -27,7 +27,7 @@ $q(document).ready(function() {
 
 	var generate = function($, linkIndex) {
 
-		var $nameInput = $('input[name=name]');
+		var $nameInput = $('input[name="p::name"]');
 
 		$nameInput.val(text);