You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by "xinrong-meng (via GitHub)" <gi...@apache.org> on 2023/04/15 03:50:35 UTC

[GitHub] [spark-website] xinrong-meng opened a new pull request, #454: Improve instructions for the release process

xinrong-meng opened a new pull request, #454:
URL: https://github.com/apache/spark-website/pull/454

   Improve instructions for the release process, specifically, the `Finalize the release` step.
   
   That includes
   - point out which steps have been automated
   - details to pay attention to
   - typo fixing
   - more clear steps by naming


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


[GitHub] [spark-website] srowen commented on pull request #454: Improve instructions for the release process

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #454:
URL: https://github.com/apache/spark-website/pull/454#issuecomment-1509936419

   Merged to asf-site


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


[GitHub] [spark-website] viirya commented on a diff in pull request #454: Improve instructions for the release process

Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #454:
URL: https://github.com/apache/spark-website/pull/454#discussion_r1169138426


##########
release-process.md:
##########
@@ -186,6 +186,18 @@ that looks something like `[VOTE][RESULT] ...`.
 
 <h3>Finalize the release</h3>
 
+Note that `dev/create-release/do-release-docker.sh` script (`finalize` step ) automates most of the following steps **except** for:
+- Publish to CRAN

Review Comment:
   Hm? Last time I did release I remember I still need to do `twine upload`, has it changed?
   
   EDIT: it was changed by SPARK-35872.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


[GitHub] [spark-website] xinrong-meng commented on a diff in pull request #454: Improve instructions for the release process

Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on code in PR #454:
URL: https://github.com/apache/spark-website/pull/454#discussion_r1169032103


##########
release-process.md:
##########
@@ -186,6 +186,18 @@ that looks something like `[VOTE][RESULT] ...`.
 
 <h3>Finalize the release</h3>
 
+Note that `dev/create-release/do-release-docker.sh` script (`finalize` step ) automates most of the following steps **except** for:
+- Publish to CRAN

Review Comment:
   "Uploading PySpark to PyPi" is automated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


[GitHub] [spark-website] xinrong-meng commented on pull request #454: Improve instructions for the release process

Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on PR #454:
URL: https://github.com/apache/spark-website/pull/454#issuecomment-1509490447

   Would you please review it? @dongjoon-hyun @HyukjinKwon @gengliangwang @viirya  @ueshin @gatorsmile 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


[GitHub] [spark-website] viirya commented on a diff in pull request #454: Improve instructions for the release process

Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #454:
URL: https://github.com/apache/spark-website/pull/454#discussion_r1167580828


##########
release-process.md:
##########
@@ -186,6 +186,18 @@ that looks something like `[VOTE][RESULT] ...`.
 
 <h3>Finalize the release</h3>
 
+Note that `dev/create-release/do-release-docker.sh` script (`finalize` step ) automates most of the following steps **except** for:
+- Publish to CRAN

Review Comment:
   PyPI?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


[GitHub] [spark-website] xinrong-meng commented on pull request #454: Improve instructions for the release process

Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on PR #454:
URL: https://github.com/apache/spark-website/pull/454#issuecomment-1511752634

   Thanks @srowen !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


[GitHub] [spark-website] viirya commented on a diff in pull request #454: Improve instructions for the release process

Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #454:
URL: https://github.com/apache/spark-website/pull/454#discussion_r1167580868


##########
release-process.md:
##########
@@ -186,6 +186,18 @@ that looks something like `[VOTE][RESULT] ...`.
 
 <h3>Finalize the release</h3>
 
+Note that `dev/create-release/do-release-docker.sh` script (`finalize` step ) automates most of the following steps **except** for:
+- Publish to CRAN
+- Update the configuration of Algolia Crawler
+- Remove old releases from Mirror Network
+- Update the rest of the Spark website
+- Create and upload Spark Docker Images
+- Create an announcement
+
+Please manually verify the result after each step.
+
+<h4>Upload to Apache release directory</h4>

Review Comment:
   Isn't this step also manual?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


[GitHub] [spark-website] xinrong-meng commented on a diff in pull request #454: Improve instructions for the release process

Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on code in PR #454:
URL: https://github.com/apache/spark-website/pull/454#discussion_r1169034199


##########
release-process.md:
##########
@@ -186,6 +186,18 @@ that looks something like `[VOTE][RESULT] ...`.
 
 <h3>Finalize the release</h3>
 
+Note that `dev/create-release/do-release-docker.sh` script (`finalize` step ) automates most of the following steps **except** for:
+- Publish to CRAN
+- Update the configuration of Algolia Crawler
+- Remove old releases from Mirror Network
+- Update the rest of the Spark website
+- Create and upload Spark Docker Images
+- Create an announcement
+
+Please manually verify the result after each step.
+
+<h4>Upload to Apache release directory</h4>

Review Comment:
   See more at https://github.com/xinrong-meng/spark/blob/master/dev/create-release/release-build.sh#L97. : )



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


[GitHub] [spark-website] viirya commented on a diff in pull request #454: Improve instructions for the release process

Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #454:
URL: https://github.com/apache/spark-website/pull/454#discussion_r1169138426


##########
release-process.md:
##########
@@ -186,6 +186,18 @@ that looks something like `[VOTE][RESULT] ...`.
 
 <h3>Finalize the release</h3>
 
+Note that `dev/create-release/do-release-docker.sh` script (`finalize` step ) automates most of the following steps **except** for:
+- Publish to CRAN

Review Comment:
   Hm? Last time I did release I remember I still need to do `twine upload`, has it changed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


[GitHub] [spark-website] xinrong-meng commented on a diff in pull request #454: Improve instructions for the release process

Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on code in PR #454:
URL: https://github.com/apache/spark-website/pull/454#discussion_r1169032739


##########
release-process.md:
##########
@@ -186,6 +186,18 @@ that looks something like `[VOTE][RESULT] ...`.
 
 <h3>Finalize the release</h3>
 
+Note that `dev/create-release/do-release-docker.sh` script (`finalize` step ) automates most of the following steps **except** for:
+- Publish to CRAN
+- Update the configuration of Algolia Crawler
+- Remove old releases from Mirror Network
+- Update the rest of the Spark website
+- Create and upload Spark Docker Images
+- Create an announcement
+
+Please manually verify the result after each step.
+
+<h4>Upload to Apache release directory</h4>

Review Comment:
   "Moving Spark binaries to the release directory" is automated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


[GitHub] [spark-website] viirya commented on a diff in pull request #454: Improve instructions for the release process

Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #454:
URL: https://github.com/apache/spark-website/pull/454#discussion_r1169148125


##########
release-process.md:
##########
@@ -186,6 +186,18 @@ that looks something like `[VOTE][RESULT] ...`.
 
 <h3>Finalize the release</h3>
 
+Note that `dev/create-release/do-release-docker.sh` script (`finalize` step ) automates most of the following steps **except** for:
+- Publish to CRAN
+- Update the configuration of Algolia Crawler
+- Remove old releases from Mirror Network
+- Update the rest of the Spark website
+- Create and upload Spark Docker Images
+- Create an announcement
+
+Please manually verify the result after each step.
+
+<h4>Upload to Apache release directory</h4>

Review Comment:
   Oh, it was changed by SPARK-35872. 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


[GitHub] [spark-website] srowen closed pull request #454: Improve instructions for the release process

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #454: Improve instructions for the release process
URL: https://github.com/apache/spark-website/pull/454


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org


[GitHub] [spark-website] xinrong-meng commented on pull request #454: Improve instructions for the release process

Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on PR #454:
URL: https://github.com/apache/spark-website/pull/454#issuecomment-1509491301

   We should submit the form linked in the description. More instructions are given when filling out the form.
   I was able to fill it out independently without "further manual steps from PMC".
   Would you prefer to remove the last sentence? @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org