You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/15 05:09:23 UTC

[GitHub] [incubator-nuttx] YuuichiNakamura opened a new pull request #1789: Fix cxd56 uart deadlock

YuuichiNakamura opened a new pull request #1789:
URL: https://github.com/apache/incubator-nuttx/pull/1789


   ## Summary
   - This commit fixes a deadlock problem in up_txint() for cxd56xx.
   - Because uart_xmitchars() called by up_txint() takes a lock by enter_critical_section(), taking a spinlock here can cause a deadlock.
   
   ## Impact
   - This commit affects the cxd56_serial driver in SMP mode only.
   
   ## Testing
   - Tested with spresense:smp
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] masayuki2009 merged pull request #1789: Fix cxd56 uart deadlock

Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #1789:
URL: https://github.com/apache/incubator-nuttx/pull/1789


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] YuuichiNakamura commented on pull request #1789: Fix cxd56 uart deadlock

Posted by GitBox <gi...@apache.org>.
YuuichiNakamura commented on pull request #1789:
URL: https://github.com/apache/incubator-nuttx/pull/1789#issuecomment-692467762


   @masayuki2009 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1789: Fix cxd56 uart deadlock

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #1789:
URL: https://github.com/apache/incubator-nuttx/pull/1789#issuecomment-692475442


   @YuuichiNakamura 
   
   Thanks for the fix.
   LGTM.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org