You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/10/20 19:03:43 UTC

Re: [PR] Add workflows to README [beam]

Abacn commented on code in PR #29096:
URL: https://github.com/apache/beam/pull/29096#discussion_r1367397696


##########
.github/workflows/beam_PerformanceTests_SingleStoreIO.yml:
##########
@@ -15,14 +15,15 @@
 # specific language governing permissions and limitations
 # under the License.
 
-name: Performance Test Java SingleStoreIO 
+name: PerformanceTests SingleStoreIO

Review Comment:
   Similar for a few Load tests:
   
   ![image](https://github.com/apache/beam/assets/8010435/f8aae8e1-c691-4070-96b5-4a34024f8ddc)
   



##########
.github/workflows/beam_PerformanceTests_SingleStoreIO.yml:
##########
@@ -15,14 +15,15 @@
 # specific language governing permissions and limitations
 # under the License.
 
-name: Performance Test Java SingleStoreIO 
+name: PerformanceTests SingleStoreIO

Review Comment:
   Thanks for unifying the naming. It shows there are a few test still use "Performance Test":
   
   ![image](https://github.com/apache/beam/assets/8010435/4f815b9b-8718-488b-ba18-2133bb88100f)
   
   shall we also change them?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org