You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com> on 2012/08/21 03:11:25 UTC
Review Request: Return reference to existing NAS datastore in vCenter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6701/
-----------------------------------------------------------
Review request for cloudstack and Kelven Yang.
Description
-------
Return reference to managed object representing a NAS datastore if it already exists, instead of throwing an exception. During an upgrade, if this code path is hit, the upgrade could fail due to this exception.
This addresses bug CS-15822.
Diffs
-----
vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java fd30399
Diff: https://reviews.apache.org/r/6701/diff/
Testing
-------
Thanks,
Venkata Siva Vijayendra Bhamidipati
Re: Review Request: Return reference to existing NAS datastore in vCenter
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6701/#review10567
-----------------------------------------------------------
Ship it!
Ship It!
- Sateesh Chodapuneedi
On Aug. 21, 2012, 1:11 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6701/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2012, 1:11 a.m.)
>
>
> Review request for cloudstack and Kelven Yang.
>
>
> Description
> -------
>
> Return reference to managed object representing a NAS datastore if it already exists, instead of throwing an exception. During an upgrade, if this code path is hit, the upgrade could fail due to this exception.
>
>
> This addresses bug CS-15822.
>
>
> Diffs
> -----
>
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java fd30399
>
> Diff: https://reviews.apache.org/r/6701/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>
Re: Review Request: Return reference to existing NAS datastore in vCenter
Posted by Kelven Yang <ke...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6701/#review10587
-----------------------------------------------------------
Ship it!
Ship It!
- Kelven Yang
On Aug. 21, 2012, 1:11 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6701/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2012, 1:11 a.m.)
>
>
> Review request for cloudstack and Kelven Yang.
>
>
> Description
> -------
>
> Return reference to managed object representing a NAS datastore if it already exists, instead of throwing an exception. During an upgrade, if this code path is hit, the upgrade could fail due to this exception.
>
>
> This addresses bug CS-15822.
>
>
> Diffs
> -----
>
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java fd30399
>
> Diff: https://reviews.apache.org/r/6701/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>