You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/28 20:23:21 UTC
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #4764: Make SessionState members private
tustvold commented on code in PR #4764:
URL: https://github.com/apache/arrow-datafusion/pull/4764#discussion_r1058571180
##########
datafusion/core/src/physical_plan/planner.rs:
##########
@@ -1773,7 +1771,7 @@ impl DefaultPhysicalPlanner {
where
F: FnMut(&dyn ExecutionPlan, &dyn PhysicalOptimizerRule),
{
- let optimizers = &session_state.physical_optimizers;
+ let optimizers = session_state.physical_optimizers();
Review Comment:
This is quite a peculiar API, I'm not sure why the physical planner would be calling the optimizers and not SessionState itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org