You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bridges-dev@portals.apache.org by "Steve Bosman (JIRA)" <br...@portals.apache.org> on 2009/06/25 11:11:07 UTC
[jira] Created: (PB-91) Add windowState attribute to link, form and
rewrite tags
Add windowState attribute to link, form and rewrite tags
--------------------------------------------------------
Key: PB-91
URL: https://issues.apache.org/jira/browse/PB-91
Project: Portals Bridges
Issue Type: Improvement
Components: struts
Affects Versions: 1.0.4
Reporter: Steve Bosman
Fix For: 1.0.5
It would be useful if the link, form and rewrite tags could create links that alter the window state.
I have supplied a patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Updated: (PB-91) Add windowState attribute to link, form and
rewrite tags
Posted by "Steve Bosman (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Bosman updated PB-91:
---------------------------
Priority: Minor (was: Major)
> Add windowState attribute to link, form and rewrite tags
> --------------------------------------------------------
>
> Key: PB-91
> URL: https://issues.apache.org/jira/browse/PB-91
> Project: Portals Bridges
> Issue Type: Improvement
> Components: struts
> Affects Versions: 1.0.4
> Reporter: Steve Bosman
> Priority: Minor
> Fix For: 1.0.5
>
> Attachments: PB-91.patch
>
>
> It would be useful if the link, form and rewrite tags could create links that alter the window state.
> I have supplied a patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Updated: (PB-91) Add windowState attribute to link, form and
rewrite tags
Posted by "Steve Bosman (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Bosman updated PB-91:
---------------------------
Attachment: PB-91.patch
Added a new patch which handles portletMode as well.
Changing the portlet mode is a slightly harder modification than the one for window state because it needed a change in the StrutsPortletURL class to pick the correct request parameter, i.e. _spageview, _spageedit or _spagehelp (otherwise users would keep being sent to the default pages as declared in portlet.xml).
> Add windowState attribute to link, form and rewrite tags
> --------------------------------------------------------
>
> Key: PB-91
> URL: https://issues.apache.org/jira/browse/PB-91
> Project: Portals Bridges
> Issue Type: Improvement
> Components: struts
> Affects Versions: 1.0.4
> Reporter: Steve Bosman
> Assignee: Ate Douma
> Priority: Minor
> Fix For: 1.0.5
>
> Attachments: PB-91.patch, PB-91.patch
>
>
> It would be useful if the link, form and rewrite tags could create links that alter the window state.
> I have supplied a patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Updated: (PB-91) Add windowState attribute to link, form and
rewrite tags
Posted by "Steve Bosman (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Bosman updated PB-91:
---------------------------
Attachment: PB-91.patch
Patch tested locally using struts 1.2.9 and liferay 5.2.3 (although I see no reason for it to be version dependent)
> Add windowState attribute to link, form and rewrite tags
> --------------------------------------------------------
>
> Key: PB-91
> URL: https://issues.apache.org/jira/browse/PB-91
> Project: Portals Bridges
> Issue Type: Improvement
> Components: struts
> Affects Versions: 1.0.4
> Reporter: Steve Bosman
> Fix For: 1.0.5
>
> Attachments: PB-91.patch
>
>
> It would be useful if the link, form and rewrite tags could create links that alter the window state.
> I have supplied a patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Commented: (PB-91) Add windowState attribute to link, form
and rewrite tags
Posted by "Ate Douma (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723974#action_12723974 ]
Ate Douma commented on PB-91:
-----------------------------
Thanks for the patch!
I will review it shortly.
One enhancement I might merge in with this is also adding support for optionally setting target PortletMode as well besides the WindowState.
> Add windowState attribute to link, form and rewrite tags
> --------------------------------------------------------
>
> Key: PB-91
> URL: https://issues.apache.org/jira/browse/PB-91
> Project: Portals Bridges
> Issue Type: Improvement
> Components: struts
> Affects Versions: 1.0.4
> Reporter: Steve Bosman
> Priority: Minor
> Fix For: 1.0.5
>
> Attachments: PB-91.patch
>
>
> It would be useful if the link, form and rewrite tags could create links that alter the window state.
> I have supplied a patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Assigned: (PB-91) Add windowState attribute to link, form
and rewrite tags
Posted by "Ate Douma (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ate Douma reassigned PB-91:
---------------------------
Assignee: Ate Douma
> Add windowState attribute to link, form and rewrite tags
> --------------------------------------------------------
>
> Key: PB-91
> URL: https://issues.apache.org/jira/browse/PB-91
> Project: Portals Bridges
> Issue Type: Improvement
> Components: struts
> Affects Versions: 1.0.4
> Reporter: Steve Bosman
> Assignee: Ate Douma
> Priority: Minor
> Fix For: 1.0.5
>
> Attachments: PB-91.patch
>
>
> It would be useful if the link, form and rewrite tags could create links that alter the window state.
> I have supplied a patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org