You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jacob Hookom (JIRA)" <de...@myfaces.apache.org> on 2006/07/05 06:48:30 UTC
[jira] Created: (MYFACES-1353) HtmlResponseWriterImpl - Prematurely
Closes HTML Elements
HtmlResponseWriterImpl - Prematurely Closes HTML Elements
---------------------------------------------------------
Key: MYFACES-1353
URL: http://issues.apache.org/jira/browse/MYFACES-1353
Project: MyFaces Core
Type: Bug
Components: General
Versions: 1.1.5-SNAPSHOT
Environment: Facelets, JBoss Seam
Reporter: Jacob Hookom
Priority: Blocker
http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlResponseWriterImpl.java?view=markup
Sometimes ResponseWriters are used to supplement other markups and in JBoss Seam's Blog example, we provide RSS feeds:
he following facelets template:
>>
>> <link>foo</link>
>>
>> generates:
>>
>> <link/>foo
This is driven by the static set 's_emptyHtmlElements' where the closeIfNecessary() closes elements before they have a chance to be closed by the user of the ResponseWriter. The logic should be if the endElement is written and there's no body, then use that specialized set to determine if the element should be written as closed or not.
I'm not sure if the logic was setup to correct issues with errant Renderers, but correcting HTML markup should only be handling cases where a closed element will not work (span, div, script, etc)--- not the other way around.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1353) HtmlResponseWriterImpl -
Prematurely Closes HTML Elements
Posted by "Adam Winer (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1353?page=comments#action_12419299 ]
Adam Winer commented on MYFACES-1353:
-------------------------------------
This seems invalid to me; Seam shouldn't be using text/html to send RSS feeds. A RenderKit is responsible for vending a ResponseWriter for its content. It'd be a great feature if MyFaces Core vended a straight XML ResponseWriter - no special HTML rules - for content types like text/xml and application/rss+xml. I can donate the code for that ResponseWriter.
> HtmlResponseWriterImpl - Prematurely Closes HTML Elements
> ---------------------------------------------------------
>
> Key: MYFACES-1353
> URL: http://issues.apache.org/jira/browse/MYFACES-1353
> Project: MyFaces Core
> Type: Bug
> Components: General
> Versions: 1.1.5-SNAPSHOT
> Environment: Facelets, JBoss Seam
> Reporter: Jacob Hookom
> Priority: Blocker
>
> http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlResponseWriterImpl.java?view=markup
> Sometimes ResponseWriters are used to supplement other markups and in JBoss Seam's Blog example, we provide RSS feeds:
> he following facelets template:
> >>
> >> <link>foo</link>
> >>
> >> generates:
> >>
> >> <link/>foo
> This is driven by the static set 's_emptyHtmlElements' where the closeIfNecessary() closes elements before they have a chance to be closed by the user of the ResponseWriter. The logic should be if the endElement is written and there's no body, then use that specialized set to determine if the element should be written as closed or not.
> I'm not sure if the logic was setup to correct issues with errant Renderers, but correcting HTML markup should only be handling cases where a closed element will not work (span, div, script, etc)--- not the other way around.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (MYFACES-1353) HtmlResponseWriterImpl -
Prematurely Closes HTML Elements
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved MYFACES-1353.
-------------------------------------
Assignee: Leonardo Uribe
Fix Version/s: 2.0.1-SNAPSHOT
Resolution: Fixed
I review it and include the ideas in trinidad ResponseWriter implementations and include them in myfaces HtmlResponseWriterImpl
> HtmlResponseWriterImpl - Prematurely Closes HTML Elements
> ---------------------------------------------------------
>
> Key: MYFACES-1353
> URL: https://issues.apache.org/jira/browse/MYFACES-1353
> Project: MyFaces Core
> Issue Type: Wish
> Components: General
> Affects Versions: 1.1.5-SNAPSHOT
> Environment: Facelets, JBoss Seam
> Reporter: Jacob Hookom
> Assignee: Leonardo Uribe
> Fix For: 2.0.1-SNAPSHOT
>
>
> http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlResponseWriterImpl.java?view=markup
> Sometimes ResponseWriters are used to supplement other markups and in JBoss Seam's Blog example, we provide RSS feeds:
> he following facelets template:
> >>
> >> <link>foo</link>
> >>
> >> generates:
> >>
> >> <link/>foo
> This is driven by the static set 's_emptyHtmlElements' where the closeIfNecessary() closes elements before they have a chance to be closed by the user of the ResponseWriter. The logic should be if the endElement is written and there's no body, then use that specialized set to determine if the element should be written as closed or not.
> I'm not sure if the logic was setup to correct issues with errant Renderers, but correcting HTML markup should only be handling cases where a closed element will not work (span, div, script, etc)--- not the other way around.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.