You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/28 01:46:59 UTC
[GitHub] [pulsar] momo-jun opened a new pull request, #15360: [feature][doc] Add a note for restarting brokers with the load shedding strategy dynamically updated
momo-jun opened a new pull request, #15360:
URL: https://github.com/apache/pulsar/pull/15360
### Motivation
Add docs for #13074
### Modifications
1. Add a note for restarting brokers with the load shedding strategy dynamically updated
2. Fix deprecated links for pulsar admin CLI and typos.
The preview looks good.
### Documentation
- [ ] `doc`
(Your PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #15360: [feature][doc] Add a note for restarting brokers with the load shedding strategy dynamically updated
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15360:
URL: https://github.com/apache/pulsar/pull/15360#discussion_r861423133
##########
site2/docs/administration-load-balance.md:
##########
@@ -143,6 +143,9 @@ loadBalancerSheddingGracePeriodMinutes=30
Pulsar supports the following types of shedding strategies. From Pulsar 2.10, the **default** shedding strategy is `ThresholdShedder`.
+> **Note**<br />
Review Comment:
This solution leaves an empty line in between, which is not necessary.
<img width="829" alt="image" src="https://user-images.githubusercontent.com/60642177/165875532-268bf279-589f-4e3d-bae0-2a2e559249f7.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #15360: [feature][doc] Add a note for restarting brokers with the load shedding strategy dynamically updated
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15360:
URL: https://github.com/apache/pulsar/pull/15360#discussion_r860524964
##########
site2/docs/administration-load-balance.md:
##########
@@ -143,6 +143,9 @@ loadBalancerSheddingGracePeriodMinutes=30
Pulsar supports the following types of shedding strategies. From Pulsar 2.10, the **default** shedding strategy is `ThresholdShedder`.
+> **Note**<br />
Review Comment:
Yes, I want this layout. But it only works with "br" added this time. Without it, it looks like below:
<img width="832" alt="image" src="https://user-images.githubusercontent.com/60642177/165689647-67ea3285-3928-4a1a-9b96-b1484d18c38e.png">
Not sure what's going wrong. I thought something had been changed in the framework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15360: [feature][doc] Add a note for restarting brokers with the load shedding strategy dynamically updated
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15360:
URL: https://github.com/apache/pulsar/pull/15360#issuecomment-1111650697
@momo-jun:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15360: [feature][doc] Add a note for restarting brokers with the load shedding strategy dynamically updated
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15360:
URL: https://github.com/apache/pulsar/pull/15360#issuecomment-1111650733
@momo-jun:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #15360: [feature][doc] Add a note for restarting brokers with the load shedding strategy dynamically updated
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #15360:
URL: https://github.com/apache/pulsar/pull/15360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15360: [feature][doc] Add a note for restarting brokers with the load shedding strategy dynamically updated
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15360:
URL: https://github.com/apache/pulsar/pull/15360#discussion_r860411169
##########
site2/docs/administration-load-balance.md:
##########
@@ -143,6 +143,9 @@ loadBalancerSheddingGracePeriodMinutes=30
Pulsar supports the following types of shedding strategies. From Pulsar 2.10, the **default** shedding strategy is `ThresholdShedder`.
+> **Note**<br />
Review Comment:
do you want this layout?
<img width="673" alt="image" src="https://user-images.githubusercontent.com/50226895/165664516-28731db6-f673-4027-93e3-456e579b0c66.png">
if so, you do not need to add <br />
if no and you want there is an empty line before the next paragrahy, you can try `<br /><br />`
##########
site2/docs/administration-load-balance.md:
##########
@@ -143,6 +143,9 @@ loadBalancerSheddingGracePeriodMinutes=30
Pulsar supports the following types of shedding strategies. From Pulsar 2.10, the **default** shedding strategy is `ThresholdShedder`.
+> **Note**<br />
Review Comment:
do you want this layout?
<img width="673" alt="image" src="https://user-images.githubusercontent.com/50226895/165664516-28731db6-f673-4027-93e3-456e579b0c66.png">
if so, you do not need to add <br />
if no and you want there is an empty line before the next paragraph, you can try `<br /><br />`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on pull request #15360: [feature][doc] Add a note for restarting brokers with the load shedding strategy dynamically updated
Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15360:
URL: https://github.com/apache/pulsar/pull/15360#issuecomment-1111652556
Hi @rdhabalia @Jason918 @eolivelli @Demogorgon314 can you pls review this doc PR? Thanks.
//cc @Anonymitaet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15360: [feature][doc] Add a note for restarting brokers with the load shedding strategy dynamically updated
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15360:
URL: https://github.com/apache/pulsar/pull/15360#discussion_r860411169
##########
site2/docs/administration-load-balance.md:
##########
@@ -143,6 +143,9 @@ loadBalancerSheddingGracePeriodMinutes=30
Pulsar supports the following types of shedding strategies. From Pulsar 2.10, the **default** shedding strategy is `ThresholdShedder`.
+> **Note**<br />
Review Comment:
do you want this layout?
<img width="673" alt="image" src="https://user-images.githubusercontent.com/50226895/165664516-28731db6-f673-4027-93e3-456e579b0c66.png">
if so, you do not need to add <br />
if no and you want there is an empty line before the next paragrahy, you can try <br /><br />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15360: [feature][doc] Add a note for restarting brokers with the load shedding strategy dynamically updated
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15360:
URL: https://github.com/apache/pulsar/pull/15360#discussion_r861420789
##########
site2/docs/administration-load-balance.md:
##########
@@ -143,6 +143,9 @@ loadBalancerSheddingGracePeriodMinutes=30
Pulsar supports the following types of shedding strategies. From Pulsar 2.10, the **default** shedding strategy is `ThresholdShedder`.
+> **Note**<br />
Review Comment:
may try another layout like:
```
>**Note**
>
>xxx
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org