You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/21 05:47:22 UTC
[GitHub] [incubator-nuttx] zhuyanlinzyl opened a new pull request #5299: libxx:uclibxx: add patch use overload constructor of filebuf & ostream
zhuyanlinzyl opened a new pull request #5299:
URL: https://github.com/apache/incubator-nuttx/pull/5299
.
## Summary
Bug fix in uclibxx initalize
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5299: libxx:uclibxx: add patch use overload constructor of filebuf & ostream
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5299:
URL: https://github.com/apache/incubator-nuttx/pull/5299#issuecomment-1019656031
mistake, @zhuyanlinzyl will reopen again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5299: libxx:uclibxx: add patch use overload constructor of filebuf & ostream
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5299:
URL: https://github.com/apache/incubator-nuttx/pull/5299#discussion_r789392503
##########
File path: libs/libxx/0001-uClibcxx-ios-fix-wclog-err.patch
##########
@@ -0,0 +1,36 @@
+From 105280c3138acd01b6c1c48b7cf20fbf870df6b8 Mon Sep 17 00:00:00 2001
+From: zhuyanlin <zh...@xiaomi.com>
+Date: Tue, 12 Oct 2021 19:37:47 +0800
+Subject: [PATCH] uClibcxx:ios: fix wclog err
+
+N/A
+
+Change-Id: I5e2311c4ae906b3e3942594b98675a43f8380c3c
+---
+ src/ios.cpp | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/src/ios.cpp b/src/ios.cpp
Review comment:
need add prefix, please take a look other patch file in the same folder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #5299: libxx:uclibxx: add patch use overload constructor of filebuf & ostream
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #5299:
URL: https://github.com/apache/incubator-nuttx/pull/5299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5299: libxx:uclibxx: add patch use overload constructor of filebuf & ostream
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5299:
URL: https://github.com/apache/incubator-nuttx/pull/5299#discussion_r789490631
##########
File path: libs/libxx/0001-uclibxx-use-overload-constructor-of-filebuf-ostream.patch
##########
@@ -0,0 +1,308 @@
+From b9028c8bc1a4cd00feb5328521bdde332fefeda3 Mon Sep 17 00:00:00 2001
+From: zhuyanlin <zh...@xiaomi.com>
+Date: Mon, 27 Sep 2021 21:47:41 +0800
+Subject: [PATCH] uclibxx: use overload constructor of filebuf & ostream
+
+Instead of set valiable in Init, use overload constructor in
+filebuf & stream class
+
+Change-Id: I090432b5576eb568f92f3c147b39ad2efd8ba6b0
+---
+ include/fstream | 15 +++++++--
+ include/ios | 21 +++---------
+ include/istream | 4 +++
+ include/ostream | 8 +++++
+ include/streambuf | 6 ++--
+ src/ios.cpp | 84 ++++++++---------------------------------------
+ 6 files changed, 44 insertions(+), 94 deletions(-)
+
+diff --git a/uClibc++/include/fstream b/uClibc++/include/fstream
+index fddfa35..99a016e 100644
+--- a/uClibc++/include/fstream
++++ b/uClibc++/include/fstream
Review comment:
Here is the prefix:
https://github.com/apache/incubator-nuttx/blob/master/libs/libxx/0001-uClibcxx-basic_definitions-fix-GCC-specific-definiti.patch#L16-L17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zhuyanlinzyl commented on pull request #5299: libxx:uclibxx: add patch use overload constructor of filebuf & ostream
Posted by GitBox <gi...@apache.org>.
zhuyanlinzyl commented on pull request #5299:
URL: https://github.com/apache/incubator-nuttx/pull/5299#issuecomment-1019661712
https://github.com/apache/incubator-nuttx/pull/5321
Please review again.
@yamt @xiaoxiang781216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5299: libxx:uclibxx: add patch use overload constructor of filebuf & ostream
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5299:
URL: https://github.com/apache/incubator-nuttx/pull/5299#issuecomment-1019592474
@xiaoxiang781216 why closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org