You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/11/07 17:54:12 UTC
[GitHub] [accumulo] ctubbsii opened a new pull request, #3070: Minor thrift utility improvements
ctubbsii opened a new pull request, #3070:
URL: https://github.com/apache/accumulo/pull/3070
* Remove unused overloaded TServerUtils.startTServer method
* Inline overloaded ThriftUtil.transportFactory method used once
* Relocate TServerUtilsTest unit test to same package as TServerUtils
* Narrow visibility of TServerUtils methods to private or package-private where possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on a diff in pull request #3070: Minor thrift utility improvements
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on code in PR #3070:
URL: https://github.com/apache/accumulo/pull/3070#discussion_r1015744222
##########
server/base/src/main/java/org/apache/accumulo/server/rpc/TServerUtils.java:
##########
@@ -591,34 +590,19 @@ public static ServerAddress startTServer(final AccumuloConfiguration conf,
}
}
- /**
- * @see #startTServer(ThriftServerType, TimedProcessor, TProtocolFactory, String, String, int,
- * long, AccumuloConfiguration, long, long, SslConnectionParams, SaslServerConnectionParams,
- * long, HostAndPort...)
- */
- public static ServerAddress startTServer(ThriftServerType serverType, TimedProcessor processor,
- String serverName, String threadName, int numThreads, long threadTimeOut,
- final AccumuloConfiguration conf, long timeBetweenThreadChecks, long maxMessageSize,
- SslConnectionParams sslParams, SaslServerConnectionParams saslParams,
- long serverSocketTimeout, HostAndPort... addresses) throws TTransportException {
- return startTServer(serverType, processor, ThriftUtil.protocolFactory(), serverName, threadName,
- numThreads, threadTimeOut, conf, timeBetweenThreadChecks, maxMessageSize, sslParams,
- saslParams, serverSocketTimeout, addresses);
- }
-
/**
* Start the appropriate Thrift server (SSL or non-blocking server) for the given parameters.
* Non-null SSL parameters will cause an SSL server to be started.
*
* @return A ServerAddress encapsulating the Thrift server created and the host/port which it is
* bound to.
*/
- public static ServerAddress startTServer(ThriftServerType serverType, TimedProcessor processor,
- TProtocolFactory protocolFactory, String serverName, String threadName, int numThreads,
- long threadTimeOut, final AccumuloConfiguration conf, long timeBetweenThreadChecks,
- long maxMessageSize, SslConnectionParams sslParams, SaslServerConnectionParams saslParams,
Review Comment:
It looks like this is currently being used in accumulo-proxy, [here](https://github.com/apache/accumulo-proxy/blob/95f9c908bc086a049c322191ec9a8e767f886773/src/main/java/org/apache/accumulo/proxy/Proxy.java#L270). Not sure if that should influence whether or not this is kept but thought I should point it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3070: Minor thrift utility improvements
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on code in PR #3070:
URL: https://github.com/apache/accumulo/pull/3070#discussion_r1015810321
##########
server/base/src/main/java/org/apache/accumulo/server/rpc/TServerUtils.java:
##########
@@ -591,34 +590,19 @@ public static ServerAddress startTServer(final AccumuloConfiguration conf,
}
}
- /**
- * @see #startTServer(ThriftServerType, TimedProcessor, TProtocolFactory, String, String, int,
- * long, AccumuloConfiguration, long, long, SslConnectionParams, SaslServerConnectionParams,
- * long, HostAndPort...)
- */
- public static ServerAddress startTServer(ThriftServerType serverType, TimedProcessor processor,
- String serverName, String threadName, int numThreads, long threadTimeOut,
- final AccumuloConfiguration conf, long timeBetweenThreadChecks, long maxMessageSize,
- SslConnectionParams sslParams, SaslServerConnectionParams saslParams,
- long serverSocketTimeout, HostAndPort... addresses) throws TTransportException {
- return startTServer(serverType, processor, ThriftUtil.protocolFactory(), serverName, threadName,
- numThreads, threadTimeOut, conf, timeBetweenThreadChecks, maxMessageSize, sslParams,
- saslParams, serverSocketTimeout, addresses);
- }
-
/**
* Start the appropriate Thrift server (SSL or non-blocking server) for the given parameters.
* Non-null SSL parameters will cause an SSL server to be started.
*
* @return A ServerAddress encapsulating the Thrift server created and the host/port which it is
* bound to.
*/
- public static ServerAddress startTServer(ThriftServerType serverType, TimedProcessor processor,
- TProtocolFactory protocolFactory, String serverName, String threadName, int numThreads,
- long threadTimeOut, final AccumuloConfiguration conf, long timeBetweenThreadChecks,
- long maxMessageSize, SslConnectionParams sslParams, SaslServerConnectionParams saslParams,
Review Comment:
It's not public API. I wonder if we can avoid using it in the proxy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #3070: Minor thrift utility improvements
Posted by GitBox <gi...@apache.org>.
ctubbsii merged PR #3070:
URL: https://github.com/apache/accumulo/pull/3070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org