You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by karensmolermiller <gi...@git.apache.org> on 2017/06/28 20:05:29 UTC
[GitHub] geode pull request #610: GEODE-3146 Remove doc reference to GemFire 8.2
GitHub user karensmolermiller opened a pull request:
https://github.com/apache/geode/pull/610
GEODE-3146 Remove doc reference to GemFire 8.2
@lgallinat @dschneider-pivotal @nreich @pivotal-eshu @agingade @joeymcallister @davebarnes97 plus any others who care, please review this PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karensmolermiller/geode feature/GEODE-3146
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/610.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #610
----
commit 9c49660313883a8150a710421c035d71ca3c90c9
Author: Karen Miller <km...@pivotal.io>
Date: 2017-06-28T18:28:01Z
GEODE-3146 Remove doc reference to GemFire 8.2
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #610: GEODE-3146 Remove doc reference to GemFire 8.2
Posted by karensmolermiller <gi...@git.apache.org>.
Github user karensmolermiller commented on the issue:
https://github.com/apache/geode/pull/610
Reviewers, please consider this PR despite the failed build. From the detail, the failure was from a spotless failure in an unrelated code commit (copied here):
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':geode-core:spotlessJavaCheck'.
> Format violations were found. Run 'gradlew spotlessApply' to fix them.
geode-
core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #610: GEODE-3146 Remove doc reference to GemFire 8.2
Posted by dschneider-pivotal <gi...@git.apache.org>.
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/610#discussion_r124667734
--- Diff: geode-docs/developing/partitioned_regions/set_join_redundancy_recovery.html.md.erb ---
@@ -19,23 +19,38 @@ See the License for the specific language governing permissions and
limitations under the License.
-->
-Configure whether and how redundancy is recovered in a partition region after a member joins.
+This section covers configuring whether and how redundancy is
+recovered in a partitioned region, after a member joins.
<a id="set_join_redundancy_recovery__section_D6FB0D69CC454B53B9CF1E656A44465C"></a>
Use the partition attribute `startup-recovery-delay` to specify member join redundancy recovery.
-| startup-recovery-delay partition attribute | Effect following a member join |
+| value of `startup-recovery-delay` | Effect following a member join |
|--------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| -1 | No automatic recovery of redundancy after a new member comes online. If you use this and the default `recovery-delay` setting, you can only recover redundancy by kicking off rebalancing through a cacheserver or API call. |
-| long greater than or equal to **0** | Number of milliseconds to wait after a member joins before before recovering redundancy. The default is 0 (zero), which causes immediate redundancy recovery whenever a new partitioned region host joins. |
-
-Setting this to a value higher than the default of 0 allows multiple new members to join before redundancy recovery kicks in. With the multiple members present during recovery, the system will spread redundancy recovery among them. With no delay, if multiple members are started in close succession, the system may choose only the first member started for most or all of the redundancy recovery.
-
-**Note:**
-Satisfying redundancy is not the same as adding capacity. If redundancy is satisfied, new members do not take buckets until you invoke a rebalance.
+| -1 | No automatic recovery of redundancy after a new member comes online. With this value and the default `recovery-delay` setting, redundancy recovery is only achieved by a rebalance operation. |
+| long integer greater than or equal to **0** | Number of milliseconds to wait after a member joins before recovering redundancy. The default is 0 (zero), which causes immediate redundancy recovery whenever a member that hosts the partitioned region joins. |
--- End diff --
I find "long integer greater" more confusing than the old "long greater". "long" and "integer" can both be used to indicate a specific Java ordinal type so having both of them is confusing.
In this context I think ">=0" would work. If you want to keep it verbose perhaps changing the old "long" to something more generic like "number" or "value" would be better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #610: GEODE-3146 Remove doc reference to GemFire 8.2
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/610
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---