You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2019/01/07 21:50:51 UTC
[GitHub] codecov-io edited a comment on issue #3624: [PINOT-7370] Return
number of bytes read from the reader interfaces/implementations
codecov-io edited a comment on issue #3624: [PINOT-7370] Return number of bytes read from the reader interfaces/implementations
URL: https://github.com/apache/incubator-pinot/pull/3624#issuecomment-449532959
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3624?src=pr&el=h1) Report
> Merging [#3624](https://codecov.io/gh/apache/incubator-pinot/pull/3624?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/09eb0150dec47a28d5a4517e4930183eb5dfd0af?src=pr&el=desc) will **decrease** coverage by `21.13%`.
> The diff coverage is `70.14%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3624?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3624 +/- ##
=============================================
- Coverage 70.95% 49.81% -21.14%
Complexity 4 4
=============================================
Files 1012 1160 +148
Lines 46450 58864 +12414
Branches 6212 8129 +1917
=============================================
- Hits 32957 29324 -3633
- Misses 11320 27374 +16054
+ Partials 2173 2166 -7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3624?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...om/linkedin/pinot/core/common/BaseBlockValSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/3624/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2NvbW1vbi9CYXNlQmxvY2tWYWxTZXQuamF2YQ==) | `4.16% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ot/controller/helix/core/util/HelixSetupUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/3624/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvdXRpbC9IZWxpeFNldHVwVXRpbHMuamF2YQ==) | `65.67% <ø> (+1.9%)` | `0 <0> (ø)` | :arrow_down: |
| [.../core/io/util/DictionaryDelegatingValueReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3624/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2lvL3V0aWwvRGljdGlvbmFyeURlbGVnYXRpbmdWYWx1ZVJlYWRlci5qYXZh) | `21.42% <0%> (-9.35%)` | `0 <0> (ø)` | |
| [...m/linkedin/pinot/broker/api/RequestStatistics.java](https://codecov.io/gh/apache/incubator-pinot/pull/3624/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9hcGkvUmVxdWVzdFN0YXRpc3RpY3MuamF2YQ==) | `0% <0%> (-71.43%)` | `0 <0> (ø)` | |
| [...gment/index/readers/ImmutableDictionaryReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3624/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3NlZ21lbnQvaW5kZXgvcmVhZGVycy9JbW11dGFibGVEaWN0aW9uYXJ5UmVhZGVyLmphdmE=) | `94.3% <100%> (+0.04%)` | `0 <0> (ø)` | :arrow_down: |
| [...ot/core/segment/index/readers/BytesDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3624/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3NlZ21lbnQvaW5kZXgvcmVhZGVycy9CeXRlc0RpY3Rpb25hcnkuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...t/core/segment/index/readers/StringDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3624/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3NlZ21lbnQvaW5kZXgvcmVhZGVycy9TdHJpbmdEaWN0aW9uYXJ5LmphdmE=) | `94.11% <100%> (-5.89%)` | `0 <0> (ø)` | |
| [...pinot/core/io/util/FixedByteValueReaderWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3624/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2lvL3V0aWwvRml4ZWRCeXRlVmFsdWVSZWFkZXJXcml0ZXIuamF2YQ==) | `88.09% <100%> (+0.59%)` | `0 <0> (ø)` | :arrow_down: |
| [...pinot/core/operator/docvalsets/SingleValueSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/3624/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY3ZhbHNldHMvU2luZ2xlVmFsdWVTZXQuamF2YQ==) | `90.78% <100%> (-0.88%)` | `0 <0> (ø)` | |
| [...not/core/segment/index/readers/BaseDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3624/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3NlZ21lbnQvaW5kZXgvcmVhZGVycy9CYXNlRGljdGlvbmFyeS5qYXZh) | `44.73% <28.57%> (-8.39%)` | `0 <0> (ø)` | |
| ... and [468 more](https://codecov.io/gh/apache/incubator-pinot/pull/3624/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3624?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3624?src=pr&el=footer). Last update [09eb015...ae401ab](https://codecov.io/gh/apache/incubator-pinot/pull/3624?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org