You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Taragolis (via GitHub)" <gi...@apache.org> on 2024/03/20 21:29:34 UTC

[I] Change `CohereHook.get_conn` type from property to method in the next major `apache-airflow-providers-cohere` [airflow]

Taragolis opened a new issue, #38350:
URL: https://github.com/apache/airflow/issues/38350

   ### Body
   
   `CohereHook` change use property
   https://github.com/apache/airflow/blob/9f9ae33a8bf69683b0e576ba35bd3450861a8cdf/airflow/providers/cohere/hooks/cohere.py#L55-L56
   
   Instead of method
   https://github.com/apache/airflow/blob/9f9ae33a8bf69683b0e576ba35bd3450861a8cdf/airflow/hooks/base.py#L98-L100
   
   Should be changed into the next major version.
   
   For save caching it might be changed to something like (just for a reference)
   
   ```python
   class CohereHook(BaseHook):
       ...
       def get_conn(self) -> client.Cohere: 
       """Some useful docstring""" 
           return self.client
       
       @cached_property
       def get_conn(self) -> client.Cohere: 
       """Some useful docstring""" 
           ... # Some implementation for obtain client here
   ```
   
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Change `CohereHook.get_conn` type from property to method in the next major `apache-airflow-providers-cohere` [airflow]

Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal closed issue #38350: Change `CohereHook.get_conn` type from property to method in the next major `apache-airflow-providers-cohere`
URL: https://github.com/apache/airflow/issues/38350


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Change `CohereHook.get_conn` type from property to method in the next major `apache-airflow-providers-cohere` [airflow]

Posted by "sjyangkevin (via GitHub)" <gi...@apache.org>.
sjyangkevin commented on issue #38350:
URL: https://github.com/apache/airflow/issues/38350#issuecomment-2869958691

   Hi, I found this from the new contributors channel, and I am interested in working on it. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Change `CohereHook.get_conn` type from property to method in the next major `apache-airflow-providers-cohere` [airflow]

Posted by "sjyangkevin (via GitHub)" <gi...@apache.org>.
sjyangkevin commented on issue #38350:
URL: https://github.com/apache/airflow/issues/38350#issuecomment-2870213885

   Hi,
   
   I have raised a PR for this issue https://github.com/apache/airflow/pull/50470. Let me know if there is any feedback or things to change. Thank you for your time to review in advance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Change `CohereHook.get_conn` type from property to method in the next major `apache-airflow-providers-cohere` [airflow]

Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on issue #38350:
URL: https://github.com/apache/airflow/issues/38350#issuecomment-2786057118

   @okirialbert following https://github.com/apache/airflow/pull/45267 can you look into this one as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org