You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "0xdeadbeer (via GitHub)" <gi...@apache.org> on 2023/08/06 15:24:36 UTC

[GitHub] [apisix-dashboard] 0xdeadbeer opened a new pull request, #2849: feat: add loki-logger plugin support

0xdeadbeer opened a new pull request, #2849:
URL: https://github.com/apache/apisix-dashboard/pull/2849

   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   Add support for the loki-logger plugin.
   
   **Related issues**
   
   #2847
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: add loki-logger plugin support [apisix-dashboard]

Posted by "juzhiyuan (via GitHub)" <gi...@apache.org>.
juzhiyuan commented on PR #2849:
URL: https://github.com/apache/apisix-dashboard/pull/2849#issuecomment-2813556865

   Thank you for your PR. We will create the new dashboard to resolve this issue. Refer to https://github.com/apache/apisix-dashboard/issues/2981


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2849: feat: add loki-logger plugin support

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2849:
URL: https://github.com/apache/apisix-dashboard/pull/2849#issuecomment-1667043661

   ## [Codecov](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2849?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#2849](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2849?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9776781) into [master](https://app.codecov.io/gh/apache/apisix-dashboard/commit/e0290c81cb3972978f0d1e3066db4d17dc6c14d1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e0290c8) will **decrease** coverage by `27.54%`.
   > Report is 1 commits behind head on master.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 9776781 differs from pull request most recent head f17de1f. Consider uploading reports for the commit f17de1f to get more accurate results
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #2849       +/-   ##
   ===========================================
   - Coverage   77.49%   49.95%   -27.54%     
   ===========================================
     Files         139       47       -92     
     Lines        3746     3439      -307     
     Branches      881        0      -881     
   ===========================================
   - Hits         2903     1718     -1185     
   - Misses        843     1511      +668     
   - Partials        0      210      +210     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-unit-test | `49.95% <ø> (?)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 186 files with indirect coverage changes](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2849/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: add loki-logger plugin support [apisix-dashboard]

Posted by "juzhiyuan (via GitHub)" <gi...@apache.org>.
juzhiyuan closed pull request #2849: feat: add loki-logger plugin support
URL: https://github.com/apache/apisix-dashboard/pull/2849


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: add loki-logger plugin support [apisix-dashboard]

Posted by "MShawNYSED (via GitHub)" <gi...@apache.org>.
MShawNYSED commented on PR #2849:
URL: https://github.com/apache/apisix-dashboard/pull/2849#issuecomment-2706827124

   + interest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org