[GitHub] [arrow-rs] HaoYang670 edited a comment on pull request #1512: Speed up the `substring` kernel

[GitBox <gi...@apache.org>]

HaoYang670 edited a comment on pull request #1512:
URL: https://github.com/apache/arrow-rs/pull/1512#issuecomment-1085574499


   Hi @Dandandan ! These are some changes since your last review:
   1. Use dynamic `Fn` trait with `Box`, so that there is no repeated code.
   2. Give up using purely functional way. Because it is not suitable in this context. `mut vec` and `for each` are more straightforward.
   3. We have to materialize `new_offset`, `new_length`(`new_end` now) and `new_start` before calculating `new_value`. Because we need `new_offset` to estimate the size of array. And `new_offset` depends on `new_length` which depends on `new_start`.
   4. `dyn Fn` may introduce just a little performance penalty. I have updated the benchmark.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org