You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/08 23:41:00 UTC
[GitHub] [spark] allisonwang-db commented on a diff in pull request #37099: [SPARK-37287][SQL] Pull out dynamic partition and bucket sort from FileFormatWriter
allisonwang-db commented on code in PR #37099:
URL: https://github.com/apache/spark/pull/37099#discussion_r917188294
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3781,6 +3781,14 @@ object SQLConf {
.intConf
.createWithDefault(0)
+ val PLANNED_WRITE_ENABLED = buildConf("spark.sql.plannedWrite.enabled")
Review Comment:
Indeed the name is not very descriptive. `Planned write` here means we want to explicitly plan file writes instead of adding various operations when executing the write. It could include things other than required ordering in the future. I am happy to brainstorm more here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org