You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "William A. Rowe Jr." <wr...@rowe-clan.net> on 2011/12/05 07:50:59 UTC

Re: svn commit: r1210287 [6/12] - in /httpd/httpd/branches/2.4.x: ./ modules/aaa/ modules/arch/netware/ modules/arch/unix/ modules/arch/win32/ modules/cache/ modules/cluster/ modules/core/ modules/database/ modules/dav/fs/ modules/dav/main/ modules/echo/ m...

On 12/4/2011 6:08 PM, sf@apache.org wrote:
> -            ap_log_error(APLOG_MARK, APLOG_ERR, rc, s,
> +            ap_log_error(APLOG_MARK, APLOG_ERR, rc, s, APLOGNO(00654)

Did you really mean for these to be in octal?

Re: svn commit: r1210287 [6/12] - in /httpd/httpd/branches/2.4.x: ./ modules/aaa/ modules/arch/netware/ modules/arch/unix/ modules/arch/win32/ modules/cache/ modules/cluster/ modules/core/ modules/database/ modules/dav/fs/ modules/dav/main/ modules/echo/ m...

Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On 12/5/2011 2:31 AM, Rainer Jung wrote:
> Hi Bill,
> 
> On 05.12.2011 07:50, William A. Rowe Jr. wrote:
>> On 12/4/2011 6:08 PM, sf@apache.org wrote:
>>> -            ap_log_error(APLOG_MARK, APLOG_ERR, rc, s,
>>> +            ap_log_error(APLOG_MARK, APLOG_ERR, rc, s, APLOGNO(00654)
>>
>> Did you really mean for these to be in octal?
> 
> APLOGNO is the following macro (see http_log.h):
> 
> #define APLOGNO(n)              "AH" #n ": "
> 
> So it turns the argument into a string. I expect the macro to be expanded by the
> preprocessor before the compiler has a chance to interpret the argument as octal.

Sounds correct, thanks.


Re: svn commit: r1210287 [6/12] - in /httpd/httpd/branches/2.4.x: ./ modules/aaa/ modules/arch/netware/ modules/arch/unix/ modules/arch/win32/ modules/cache/ modules/cluster/ modules/core/ modules/database/ modules/dav/fs/ modules/dav/main/ modules/echo/ m...

Posted by Rainer Jung <ra...@kippdata.de>.
Hi Bill,

On 05.12.2011 07:50, William A. Rowe Jr. wrote:
> On 12/4/2011 6:08 PM, sf@apache.org wrote:
>> -            ap_log_error(APLOG_MARK, APLOG_ERR, rc, s,
>> +            ap_log_error(APLOG_MARK, APLOG_ERR, rc, s, APLOGNO(00654)
>
> Did you really mean for these to be in octal?

APLOGNO is the following macro (see http_log.h):

#define APLOGNO(n)              "AH" #n ": "

So it turns the argument into a string. I expect the macro to be 
expanded by the preprocessor before the compiler has a chance to 
interpret the argument as octal.

Regards,

Rainer

Re: svn commit: r1210287 [6/12] - in /httpd/httpd/branches/2.4.x: ./ modules/aaa/ modules/arch/netware/ modules/arch/unix/ modules/arch/win32/ modules/cache/ modules/cluster/ modules/core/ modules/database/ modules/dav/fs/ modules/dav/main/ modules/echo/ m...

Posted by Rainer Jung <ra...@kippdata.de>.
Hi Bill,

On 05.12.2011 07:50, William A. Rowe Jr. wrote:
> On 12/4/2011 6:08 PM, sf@apache.org wrote:
>> -            ap_log_error(APLOG_MARK, APLOG_ERR, rc, s,
>> +            ap_log_error(APLOG_MARK, APLOG_ERR, rc, s, APLOGNO(00654)
>
> Did you really mean for these to be in octal?

APLOGNO is the following macro (see http_log.h):

#define APLOGNO(n)              "AH" #n ": "

So it turns the argument into a string. I expect the macro to be 
expanded by the preprocessor before the compiler has a chance to 
interpret the argument as octal.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-unsubscribe@httpd.apache.org
For additional commands, e-mail: docs-help@httpd.apache.org