You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/05/19 19:40:01 UTC
Review Request 34420: Updated the committer doc regarding checking
JIRA before committing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34420/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone.
Repository: mesos
Description
-------
Updated the committer doc regarding checking JIRA before committing.
Diffs
-----
docs/committing.md 3aef7f26f379b6bdcf9b7be13a780ffe5ed63c6b
Diff: https://reviews.apache.org/r/34420/diff/
Testing
-------
Thanks,
Jie Yu
Re: Review Request 34420: Updated the committer doc regarding
checking JIRA before committing.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34420/#review84724
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On May 19, 2015, 10:40 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34420/
> -----------------------------------------------------------
>
> (Updated May 19, 2015, 10:40 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the committer doc regarding checking JIRA before committing.
>
>
> Diffs
> -----
>
> docs/committing.md 3aef7f26f379b6bdcf9b7be13a780ffe5ed63c6b
>
> Diff: https://reviews.apache.org/r/34420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 34420: Updated the committer doc regarding
checking JIRA before committing.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34420/#review84393
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34420]
All tests passed.
- Mesos ReviewBot
On May 19, 2015, 5:40 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34420/
> -----------------------------------------------------------
>
> (Updated May 19, 2015, 5:40 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the committer doc regarding checking JIRA before committing.
>
>
> Diffs
> -----
>
> docs/committing.md 3aef7f26f379b6bdcf9b7be13a780ffe5ed63c6b
>
> Diff: https://reviews.apache.org/r/34420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 34420: Updated the committer doc regarding
checking JIRA before committing.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34420/#review84404
-----------------------------------------------------------
Ship it!
Otherwise looks good!
- Ben Mahler
On May 19, 2015, 5:40 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34420/
> -----------------------------------------------------------
>
> (Updated May 19, 2015, 5:40 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the committer doc regarding checking JIRA before committing.
>
>
> Diffs
> -----
>
> docs/committing.md 3aef7f26f379b6bdcf9b7be13a780ffe5ed63c6b
>
> Diff: https://reviews.apache.org/r/34420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 34420: Updated the committer doc regarding
checking JIRA before committing.
Posted by Ben Mahler <be...@gmail.com>.
> On May 19, 2015, 6:53 p.m., Ben Mahler wrote:
> > Looks like we need to add a step for resolving the JIRA ticket (including the commit message in a comment), if applicable?
>
> Jie Yu wrote:
> Will add that later. Not sure if it belongs to this file, or we need to have a new doc regarding the pratices we used for JIRA?
Well, it should be done at commit time ideally. Might be nice to have some automation around resolving the JIRAs in a consistent way.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34420/#review84363
-----------------------------------------------------------
On May 19, 2015, 5:40 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34420/
> -----------------------------------------------------------
>
> (Updated May 19, 2015, 5:40 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the committer doc regarding checking JIRA before committing.
>
>
> Diffs
> -----
>
> docs/committing.md 3aef7f26f379b6bdcf9b7be13a780ffe5ed63c6b
>
> Diff: https://reviews.apache.org/r/34420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 34420: Updated the committer doc regarding
checking JIRA before committing.
Posted by Jie Yu <yu...@gmail.com>.
> On May 19, 2015, 6:53 p.m., Ben Mahler wrote:
> > Looks like we need to add a step for resolving the JIRA ticket (including the commit message in a comment), if applicable?
Will add that later. Not sure if it belongs to this file, or we need to have a new doc regarding the pratices we used for JIRA?
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34420/#review84363
-----------------------------------------------------------
On May 19, 2015, 5:40 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34420/
> -----------------------------------------------------------
>
> (Updated May 19, 2015, 5:40 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the committer doc regarding checking JIRA before committing.
>
>
> Diffs
> -----
>
> docs/committing.md 3aef7f26f379b6bdcf9b7be13a780ffe5ed63c6b
>
> Diff: https://reviews.apache.org/r/34420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 34420: Updated the committer doc regarding
checking JIRA before committing.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34420/#review84363
-----------------------------------------------------------
Looks like we need to add a step for resolving the JIRA ticket (including the commit message in a comment), if applicable?
- Ben Mahler
On May 19, 2015, 5:40 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34420/
> -----------------------------------------------------------
>
> (Updated May 19, 2015, 5:40 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the committer doc regarding checking JIRA before committing.
>
>
> Diffs
> -----
>
> docs/committing.md 3aef7f26f379b6bdcf9b7be13a780ffe5ed63c6b
>
> Diff: https://reviews.apache.org/r/34420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>