You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "dhruba borthakur (JIRA)" <ji...@apache.org> on 2007/01/30 01:01:49 UTC
[jira] Created: (HADOOP-959) TestCheckpoint fails on Windows
TestCheckpoint fails on Windows
-------------------------------
Key: HADOOP-959
URL: https://issues.apache.org/jira/browse/HADOOP-959
Project: Hadoop
Issue Type: Bug
Components: dfs
Reporter: dhruba borthakur
Assigned To: dhruba borthakur
The new unit test that tests periodic checkpointing fails on Windows. The problem is that the method FSEditLog.purgeEditLog() uses renameTo() to atomically move edits.new to edits
File.renameTo() fails on Windows is not atomic: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4017593
I propose that we change this code to first try the renameTo(). If it fails, then it deletes edits and then renames edits.new to edits.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-959) TestCheckpoint fails on Windows
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468836 ]
Hadoop QA commented on HADOOP-959:
----------------------------------
+1, because http://issues.apache.org/jira/secure/attachment/12349969/renameToWindows2.patch applied and successfully tested against trunk revision r501616.
> TestCheckpoint fails on Windows
> -------------------------------
>
> Key: HADOOP-959
> URL: https://issues.apache.org/jira/browse/HADOOP-959
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Reporter: dhruba borthakur
> Assigned To: dhruba borthakur
> Attachments: renameToWindows2.patch
>
>
> The new unit test that tests periodic checkpointing fails on Windows. The problem is that the method FSEditLog.purgeEditLog() uses renameTo() to atomically move edits.new to edits
> File.renameTo() fails on Windows is not atomic: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4017593
> I propose that we change this code to first try the renameTo(). If it fails, then it deletes edits and then renames edits.new to edits.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-959) TestCheckpoint fails on Windows
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-959:
------------------------------------
Attachment: renameToWindows2.patch
Added additional documentation.
> TestCheckpoint fails on Windows
> -------------------------------
>
> Key: HADOOP-959
> URL: https://issues.apache.org/jira/browse/HADOOP-959
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Reporter: dhruba borthakur
> Assigned To: dhruba borthakur
> Attachments: renameToWindows2.patch
>
>
> The new unit test that tests periodic checkpointing fails on Windows. The problem is that the method FSEditLog.purgeEditLog() uses renameTo() to atomically move edits.new to edits
> File.renameTo() fails on Windows is not atomic: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4017593
> I propose that we change this code to first try the renameTo(). If it fails, then it deletes edits and then renames edits.new to edits.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-959) TestCheckpoint fails on Windows
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-959:
------------------------------------
Attachment: renameToWindows.patch
Here is a patch for review.
> TestCheckpoint fails on Windows
> -------------------------------
>
> Key: HADOOP-959
> URL: https://issues.apache.org/jira/browse/HADOOP-959
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Reporter: dhruba borthakur
> Assigned To: dhruba borthakur
> Attachments: renameToWindows.patch
>
>
> The new unit test that tests periodic checkpointing fails on Windows. The problem is that the method FSEditLog.purgeEditLog() uses renameTo() to atomically move edits.new to edits
> File.renameTo() fails on Windows is not atomic: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4017593
> I propose that we change this code to first try the renameTo(). If it fails, then it deletes edits and then renames edits.new to edits.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-959) TestCheckpoint fails on Windows
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-959:
------------------------------------
Status: Patch Available (was: Open)
Code reviewed by Milind.
> TestCheckpoint fails on Windows
> -------------------------------
>
> Key: HADOOP-959
> URL: https://issues.apache.org/jira/browse/HADOOP-959
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Reporter: dhruba borthakur
> Assigned To: dhruba borthakur
> Attachments: renameToWindows2.patch
>
>
> The new unit test that tests periodic checkpointing fails on Windows. The problem is that the method FSEditLog.purgeEditLog() uses renameTo() to atomically move edits.new to edits
> File.renameTo() fails on Windows is not atomic: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4017593
> I propose that we change this code to first try the renameTo(). If it fails, then it deletes edits and then renames edits.new to edits.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-959) TestCheckpoint fails on Windows
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-959:
------------------------------------
Attachment: (was: renameToWindows.patch)
> TestCheckpoint fails on Windows
> -------------------------------
>
> Key: HADOOP-959
> URL: https://issues.apache.org/jira/browse/HADOOP-959
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Reporter: dhruba borthakur
> Assigned To: dhruba borthakur
>
> The new unit test that tests periodic checkpointing fails on Windows. The problem is that the method FSEditLog.purgeEditLog() uses renameTo() to atomically move edits.new to edits
> File.renameTo() fails on Windows is not atomic: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4017593
> I propose that we change this code to first try the renameTo(). If it fails, then it deletes edits and then renames edits.new to edits.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-959) TestCheckpoint fails on Windows
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated HADOOP-959:
--------------------------------
Resolution: Fixed
Fix Version/s: 0.11.0
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Dhruba!
> TestCheckpoint fails on Windows
> -------------------------------
>
> Key: HADOOP-959
> URL: https://issues.apache.org/jira/browse/HADOOP-959
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Reporter: dhruba borthakur
> Assigned To: dhruba borthakur
> Fix For: 0.11.0
>
> Attachments: renameToWindows2.patch
>
>
> The new unit test that tests periodic checkpointing fails on Windows. The problem is that the method FSEditLog.purgeEditLog() uses renameTo() to atomically move edits.new to edits
> File.renameTo() fails on Windows is not atomic: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4017593
> I propose that we change this code to first try the renameTo(). If it fails, then it deletes edits and then renames edits.new to edits.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-959) TestCheckpoint fails on Windows
Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468812 ]
Milind Bhandarkar commented on HADOOP-959:
------------------------------------------
The comments "//renameTo fails on windows" should be more descriptive, e.g. // renameTo fails on windows if the destination exists
> TestCheckpoint fails on Windows
> -------------------------------
>
> Key: HADOOP-959
> URL: https://issues.apache.org/jira/browse/HADOOP-959
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Reporter: dhruba borthakur
> Assigned To: dhruba borthakur
> Attachments: renameToWindows.patch
>
>
> The new unit test that tests periodic checkpointing fails on Windows. The problem is that the method FSEditLog.purgeEditLog() uses renameTo() to atomically move edits.new to edits
> File.renameTo() fails on Windows is not atomic: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4017593
> I propose that we change this code to first try the renameTo(). If it fails, then it deletes edits and then renames edits.new to edits.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.