[GitHub] [beam] lukecwik commented on a change in pull request #16778: [BEAM-13193] Allow BeamFnDataOutboundObserver to flush elements.

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #16778:
URL: https://github.com/apache/beam/pull/16778#discussion_r802152443



##########
File path: sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataOutboundObserver.java
##########
@@ -73,7 +73,11 @@ public void close() throws Exception {
   }
 
   @Override
-  public void flush() throws IOException {}
+  public void flush() throws IOException {

Review comment:
       You could make periodicFlush throw IOException and invoke it instead. You would move the try/catch logic into a lambda where we schedule the thread in the constructor.
   
   It would also make sense to rename periodicFlush() to flush() and what is currently named flush() to flushInternal() since we don't want to expose the flushLock if we don't have to.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org