You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/10/30 01:13:00 UTC

[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #3322: ARTEMIS-2969 / ARTEMIS-2937 Dealing with Connection Timeout properly

clebertsuconic opened a new pull request #3322:
URL: https://github.com/apache/activemq-artemis/pull/3322


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3322: ARTEMIS-2969 / ARTEMIS-2937 Dealing with Connection Timeout properly

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3322:
URL: https://github.com/apache/activemq-artemis/pull/3322#discussion_r514657893



##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPBridgeTest.java
##########
@@ -54,17 +54,6 @@ protected ActiveMQServer createServer() throws Exception {
       return createServer(AMQP_PORT, false);
    }
 
-   @Test
-   public void testsSimpleConnect() throws Exception {

Review comment:
       This test was not doing anything at this point..
   
   I had use for it during dev, but as things progressed it is not needed any longer.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3322: ARTEMIS-2969 / ARTEMIS-2937 Dealing with Connection Timeout properly

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3322:
URL: https://github.com/apache/activemq-artemis/pull/3322#issuecomment-719111421


   I will add a test on QpidDispatchPeerTest for now.. and I will develop something more complete on next week.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] asfgit closed pull request #3322: ARTEMIS-2969 / ARTEMIS-2937 Dealing with Connection Timeout properly

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3322:
URL: https://github.com/apache/activemq-artemis/pull/3322


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] asfgit merged pull request #3322: ARTEMIS-2969 / ARTEMIS-2937 Dealing with Connection Timeout properly

Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #3322:
URL: https://github.com/apache/activemq-artemis/pull/3322


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org