You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Shuai Lin <li...@gmail.com> on 2016/01/16 16:59:52 UTC
Review Request 42390: Fixed fetching uris when slave is running
inside a container.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42390/
-----------------------------------------------------------
Review request for mesos and Timothy Chen.
Bugs: MESOS-4249
https://issues.apache.org/jira/browse/MESOS-4249
Repository: mesos
Description
-------
This still requires the slave work dir is a mounted volume, otherwise the slave has no way to fetch into the task container's sandbox.
Diffs
-----
src/slave/containerizer/docker.cpp da19975c1f1e59fab0a96ebd9aa815bba2a35ece
Diff: https://reviews.apache.org/r/42390/diff/
Testing
-------
- Start a master, then start the slave inside a docker container, with the work_dir being a mounted volume
- Start a simple framework, which, on receiving the first offer, launches a task with a uri in the command info
- When the task container is launched, check the file is fetched into the sandbox
```sh
$ docker exec <task-container-id> ls /mnt/mesos/sandbox
robots.txt
stderr
stdout
```
Thanks,
Shuai Lin
Re: Review Request 42390: Fixed fetching uris when slave is running
inside a container.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42390/#review114869
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42390]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 16, 2016, 3:59 p.m., Shuai Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42390/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 3:59 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-4249
> https://issues.apache.org/jira/browse/MESOS-4249
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This still requires the slave work dir is a mounted volume, otherwise the slave has no way to fetch into the task container's sandbox.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp da19975c1f1e59fab0a96ebd9aa815bba2a35ece
>
> Diff: https://reviews.apache.org/r/42390/diff/
>
>
> Testing
> -------
>
> - Start a master, then start the slave inside a docker container, with the work_dir being a mounted volume
> - Start a simple framework, which, on receiving the first offer, launches a task with a uri in the command info
> - When the task container is launched, check the file is fetched into the sandbox
> ```sh
> $ docker exec <task-container-id> ls /mnt/mesos/sandbox
> robots.txt
> stderr
> stdout
> ```
>
>
> Thanks,
>
> Shuai Lin
>
>
Re: Review Request 42390: Fixed fetching uris when slave is running
inside a container.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42390/#review115328
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Jan. 17, 2016, 3:33 a.m., Shuai Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42390/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2016, 3:33 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-4249
> https://issues.apache.org/jira/browse/MESOS-4249
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This still requires the slave work dir is a mounted volume, otherwise
> the slave has no way to fetch into the task container's sandbox.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp da19975c1f1e59fab0a96ebd9aa815bba2a35ece
>
> Diff: https://reviews.apache.org/r/42390/diff/
>
>
> Testing
> -------
>
> - Start a master, then start the slave inside a docker container, with the work_dir being a mounted volume
> - Start a simple framework, which, on receiving the first offer, launches a task with a uri in the command info
> - When the task container is launched, check the file is fetched into the sandbox
> ```sh
> $ docker exec <task-container-id> ls /mnt/mesos/sandbox
> robots.txt
> stderr
> stdout
> ```
>
>
> Thanks,
>
> Shuai Lin
>
>
Re: Review Request 42390: Fixed fetching uris when slave is running
inside a container.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42390/#review120516
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Jan. 20, 2016, 2:12 p.m., Shuai Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42390/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 2:12 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-4249
> https://issues.apache.org/jira/browse/MESOS-4249
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This still requires the slave work dir is a mounted volume, otherwise
> the slave has no way to fetch into the task container's sandbox.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp da19975c1f1e59fab0a96ebd9aa815bba2a35ece
>
> Diff: https://reviews.apache.org/r/42390/diff/
>
>
> Testing
> -------
>
> - Start a master, then start the slave inside a docker container, with the work_dir being a mounted volume
> - Start a simple framework, which, on receiving the first offer, launches a task with a uri in the command info
> - When the task container is launched, check the file is fetched into the sandbox
> ```sh
> $ docker exec <task-container-id> ls /mnt/mesos/sandbox
> robots.txt
> stderr
> stdout
> ```
>
> I have collected the scripts I use in testing in [this gist](https://gist.github.com/lins05/14455e92f37e91fd46ff)
>
>
> Thanks,
>
> Shuai Lin
>
>
Re: Review Request 42390: Fixed fetching uris when slave is running
inside a container.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42390/#review120296
-----------------------------------------------------------
Ship it!
Ship It!
- Klaus Ma
On Jan. 20, 2016, 10:12 p.m., Shuai Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42390/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 10:12 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-4249
> https://issues.apache.org/jira/browse/MESOS-4249
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This still requires the slave work dir is a mounted volume, otherwise
> the slave has no way to fetch into the task container's sandbox.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp da19975c1f1e59fab0a96ebd9aa815bba2a35ece
>
> Diff: https://reviews.apache.org/r/42390/diff/
>
>
> Testing
> -------
>
> - Start a master, then start the slave inside a docker container, with the work_dir being a mounted volume
> - Start a simple framework, which, on receiving the first offer, launches a task with a uri in the command info
> - When the task container is launched, check the file is fetched into the sandbox
> ```sh
> $ docker exec <task-container-id> ls /mnt/mesos/sandbox
> robots.txt
> stderr
> stdout
> ```
>
> I have collected the scripts I use in testing in [this gist](https://gist.github.com/lins05/14455e92f37e91fd46ff)
>
>
> Thanks,
>
> Shuai Lin
>
>
Re: Review Request 42390: Fixed fetching uris when slave is running
inside a container.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42390/#review115422
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On Jan. 20, 2016, 6:12 a.m., Shuai Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42390/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 6:12 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-4249
> https://issues.apache.org/jira/browse/MESOS-4249
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This still requires the slave work dir is a mounted volume, otherwise
> the slave has no way to fetch into the task container's sandbox.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp da19975c1f1e59fab0a96ebd9aa815bba2a35ece
>
> Diff: https://reviews.apache.org/r/42390/diff/
>
>
> Testing
> -------
>
> - Start a master, then start the slave inside a docker container, with the work_dir being a mounted volume
> - Start a simple framework, which, on receiving the first offer, launches a task with a uri in the command info
> - When the task container is launched, check the file is fetched into the sandbox
> ```sh
> $ docker exec <task-container-id> ls /mnt/mesos/sandbox
> robots.txt
> stderr
> stdout
> ```
>
> I have collected the scripts I use in testing in [this gist](https://gist.github.com/lins05/14455e92f37e91fd46ff)
>
>
> Thanks,
>
> Shuai Lin
>
>
Re: Review Request 42390: Fixed fetching uris when slave is running
inside a container.
Posted by Shuai Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42390/
-----------------------------------------------------------
(Updated Jan. 20, 2016, 2:12 p.m.)
Review request for mesos and Timothy Chen.
Bugs: MESOS-4249
https://issues.apache.org/jira/browse/MESOS-4249
Repository: mesos
Description
-------
This still requires the slave work dir is a mounted volume, otherwise
the slave has no way to fetch into the task container's sandbox.
Diffs
-----
src/slave/containerizer/docker.cpp da19975c1f1e59fab0a96ebd9aa815bba2a35ece
Diff: https://reviews.apache.org/r/42390/diff/
Testing (updated)
-------
- Start a master, then start the slave inside a docker container, with the work_dir being a mounted volume
- Start a simple framework, which, on receiving the first offer, launches a task with a uri in the command info
- When the task container is launched, check the file is fetched into the sandbox
```sh
$ docker exec <task-container-id> ls /mnt/mesos/sandbox
robots.txt
stderr
stdout
```
I have collected the scripts I use in testing in [this gist](https://gist.github.com/lins05/14455e92f37e91fd46ff)
Thanks,
Shuai Lin
Re: Review Request 42390: Fixed fetching uris when slave is running
inside a container.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42390/#review115397
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 一月 17, 2016, 3:33 a.m., Shuai Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42390/
> -----------------------------------------------------------
>
> (Updated 一月 17, 2016, 3:33 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-4249
> https://issues.apache.org/jira/browse/MESOS-4249
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This still requires the slave work dir is a mounted volume, otherwise
> the slave has no way to fetch into the task container's sandbox.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp da19975c1f1e59fab0a96ebd9aa815bba2a35ece
>
> Diff: https://reviews.apache.org/r/42390/diff/
>
>
> Testing
> -------
>
> - Start a master, then start the slave inside a docker container, with the work_dir being a mounted volume
> - Start a simple framework, which, on receiving the first offer, launches a task with a uri in the command info
> - When the task container is launched, check the file is fetched into the sandbox
> ```sh
> $ docker exec <task-container-id> ls /mnt/mesos/sandbox
> robots.txt
> stderr
> stdout
> ```
>
>
> Thanks,
>
> Shuai Lin
>
>
Re: Review Request 42390: Fixed fetching uris when slave is running
inside a container.
Posted by Shuai Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42390/
-----------------------------------------------------------
(Updated Jan. 17, 2016, 3:33 a.m.)
Review request for mesos and Timothy Chen.
Bugs: MESOS-4249
https://issues.apache.org/jira/browse/MESOS-4249
Repository: mesos
Description (updated)
-------
This still requires the slave work dir is a mounted volume, otherwise
the slave has no way to fetch into the task container's sandbox.
Diffs
-----
src/slave/containerizer/docker.cpp da19975c1f1e59fab0a96ebd9aa815bba2a35ece
Diff: https://reviews.apache.org/r/42390/diff/
Testing
-------
- Start a master, then start the slave inside a docker container, with the work_dir being a mounted volume
- Start a simple framework, which, on receiving the first offer, launches a task with a uri in the command info
- When the task container is launched, check the file is fetched into the sandbox
```sh
$ docker exec <task-container-id> ls /mnt/mesos/sandbox
robots.txt
stderr
stdout
```
Thanks,
Shuai Lin