[jira] [Comment Edited] (DRILL-8307) Ensure thread safety in the Druid plugin HTTP client

["James Turton (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-8307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605401#comment-17605401 ] 

James Turton edited comment on DRILL-8307 at 9/16/22 9:24 AM:
--------------------------------------------------------------

[~cgivre] this is a resend since my first attempt at this comment seems to have vanished. Both of your suggestions seem like good ways to go to me, but they don't strike me as backportable bugfixes so I think we should get a small, focussed fix out fast and the bigger improvements into the master branch separately.


was (Author: dzamo):
[~cgivre] this is a resend since my first attempt at this comment seems to have vanished. Both of your suggestions seems like good ways to go to me, but they don't strike me as backportable bugfixes so I think we should get a small, focussed fix out fast and the bigger improvements into the master branch separately.

> Ensure thread safety in the Druid plugin HTTP client
> ----------------------------------------------------
>
>                 Key: DRILL-8307
>                 URL: https://issues.apache.org/jira/browse/DRILL-8307
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - Other
>    Affects Versions: 1.20.2
>            Reporter: James Turton
>            Priority: Major
>             Fix For: 1.20.3
>
>
> When multiple concurrent queries are run against a single Druid storage plugin then an error such as is shown below is reported by the Apache HttpClient used in that plugin. The Druid storage plugin uses a single static HttpClient instance which should be replaced with something like PoolingHttpClientConnectionManager or the OkHttp3 library for multithreaded access.
> {code:java}
> [1cdd2b75-1310-xxxx-xxxx-5a638567ed07:foreman] INFO
> o.a.d.e.s.d.s.DruidSchemaFactory
> User Error Occurred: Failure while loading druid datasources for database
> 'druid-egsmd300'. (Invalid use of BasicClientConnManager: connection still
> allocated.
> Make sure to release the connection before allocating another one.)
> org.apache.drill.common.exceptions.UserException: DATA_READ ERROR: Failure
> while loading druid datasources for database '<connection name>'.
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)