[jira] [Commented] (SANTUARIO-510) Support RSASSA-PSS with Parameters

["Colm O hEigeartaigh (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SANTUARIO-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993729#comment-16993729 ] 

Colm O hEigeartaigh commented on SANTUARIO-510:
-----------------------------------------------

Hi [~kunnar] ,

Thanks for the patch, I finally got time to review. Overall it looks good, and it can go into the 2.2.0 release, which I hope to get out early next year.

There are lots of small changes I want, but I will do them myself after the patch is applied. In particular, the change to the XML Signature schema is not needed, there is a better way of handling the new element for the streaming layer.

One functional change that is needed is that it doesn't obey the spec in that "The default salt length for these SignatureMethod identifiers if the
 SaltLength is not specified SHALL be the number of octets in the hash value of the digest method", whereas the code defaults to the hard-coded length related to the digest algorithm.

[~mullan] any objections to merging the patch to trunk?

Colm.

> Support RSASSA-PSS with Parameters
> ----------------------------------
>
>                 Key: SANTUARIO-510
>                 URL: https://issues.apache.org/jira/browse/SANTUARIO-510
>             Project: Santuario
>          Issue Type: New Feature
>            Reporter: Kunnar Klauks
>            Assignee: Colm O hEigeartaigh
>            Priority: Major
>             Fix For: Java 2.2.0
>
>         Attachments: updated-rsa-pss-trunk.patch, xmlsec_2_0_1_RSAPSSParams_support.patch, xmlsec_trunk_RSAPSSParams_support.patch
>
>
> Support for 'RSASSA-PSS with Parameters' as described in [https://tools.ietf.org/html/rfc6931#section-2.3.9]
>  
> Mailing list topic [http://apache-xml-project.6118.n7.nabble.com/PATCH-RSASSA-PSS-with-Parameters-td45824.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)