[GitHub] [druid] gianm commented on pull request #14331: write factory.json use utf-8

["gianm (via GitHub)" <gi...@apache.org>]

gianm commented on PR #14331:
URL: https://github.com/apache/druid/pull/14331#issuecomment-1560343492

   hmm, I'm confused about why this mattered. In Jackson `ObjectMapper`, when we do `writeValue` on an `OutputStream`, it uses UTF-8. Here is the code from Jackson:
   
   ```java
       public void writeValue(OutputStream out, Object value)
           throws IOException, JsonGenerationException, JsonMappingException
       {
           _configAndWriteValue(_jsonFactory.createJsonGenerator(out, JsonEncoding.UTF8), value);
       }
   ```
   
   In your case, was this defeated somehow?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org