[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #917: GEODE-10004: support older geode versions

[GitBox <gi...@apache.org>]

pdxcodemonkey commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r803874498



##########
File path: CMakeLists.txt
##########
@@ -61,6 +61,7 @@ set(PRODUCT_BUILDDATE "1970-01-01" CACHE STRING "Product build date")
 set(PRODUCT_SOURCE_REVISION "0000000000000000000000000000000000000000" CACHE STRING "Product source SHA")
 set(PRODUCT_SOURCE_REPOSITORY "<unspecified>" CACHE STRING "Product source branch")
 set(PRODUCT_BITS "${BUILD_BITS}bit")
+set(GEODE_AUTHEXPIREDEXCEPTION_VERSION "1.15.0-build.546" CACHE STRING "First build containing AuthenticationExpiredException")

Review comment:
       Just because that's a more complex fix, and neither of us really have a clue how to implement it using cmake.  Like how would we do this, go dump the class list from a jar file after we find Geode?  Which of the umpteen Geode jar files should we look in?  How do we run the jar tool at this stage via cmake?  After we do or do not find the exception class, how do we put that back into a cmake variable we can use to conditionally compile our Java?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org