[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4138: add drop_role and set_default_role antlr visitor for MySQL DCLStatement

[GitBox <gi...@apache.org>]

tristaZero commented on a change in pull request #4138: add drop_role and set_default_role antlr visitor for MySQL DCLStatement
URL: https://github.com/apache/incubator-shardingsphere/pull/4138#discussion_r373825553
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java
 ##########
 @@ -249,7 +250,17 @@ public ASTNode visitShowLike(final ShowLikeContext ctx) {
     public ASTNode visitCreateUser(final CreateUserContext ctx) {
         return new DCLStatement();
     }
-
+    
+    @Override
+    public ASTNode visitDropRole(DropRoleContext ctx) {
+        return new DCLStatement();
+    }
+    
+    @Override
+    public ASTNode visitSetDefaultRole(SetDefaultRoleContext ctx) {
 
 Review comment:
   Is it necessary to add? I could find this one in `META-INF/parsing-rule-definition/mysql/sql-statement-rule-definition.xml`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services