You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/05/18 02:47:09 UTC

[GitHub] [hudi] nsivabalan commented on a change in pull request #2957: [HUDI-1888] Fix NPE when the nested partition path field has null value

nsivabalan commented on a change in pull request #2957:
URL: https://github.com/apache/hudi/pull/2957#discussion_r633996956



##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/RowKeyGeneratorHelper.java
##########
@@ -137,14 +137,15 @@ public static Object getNestedFieldVal(Row row, List<Integer> positions) {
     Object toReturn = null;
 
     while (index < totalCount) {
+      if (valueToProcess.isNullAt(positions.get(index))) {

Review comment:
       would you mind adding documentation at line 130 as to what this method is doing. I was the one who added his method, but now when I review it, took sometime to understand the full code ;) 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org