You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/07 05:37:24 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #29961: [SPARK-XXX][SQL] Remove hive-1.2 workaround code
dongjoon-hyun opened a new pull request #29961:
URL: https://github.com/apache/spark/pull/29961
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-705041924
- K8s IT passed at the first run (https://github.com/apache/spark/pull/29961#issuecomment-704732996).
- The failure on the second run is due to a flaky test.
```
KubernetesSuite:
- Run SparkPi with no resources *** FAILED ***
...
Tests: succeeded 17, failed 1, canceled 0, ignored 0, pending 0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704720549
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34097/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704733015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-705052735
This PR is ready. Could you review this PR?
@wangyum , @HyukjinKwon , @maropu , @viirya , @dbtsai , @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29961:
URL: https://github.com/apache/spark/pull/29961#discussion_r501202358
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
##########
@@ -581,7 +580,7 @@ class OrcSourceSuite extends OrcSuite with SharedSparkSession {
}
test("Enforce direct encoding column-wise selectively") {
- testSelectiveDictionaryEncoding(isSelective = true)
+ testSelectiveDictionaryEncoding(isSelective = true, isHive23 = false)
Review comment:
This is `sql/core` module. We are using Apache ORC directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-705052735
This PR is ready. Could you review this PR?
@wangyum , @HyukjinKwon , @maropu , @viirya , @dbtsai , @cloud-fan , @HeartSaVioR , @gengliangwang .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704704721
**[Test build #129491 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129491/testReport)** for PR 29961 at commit [`08edebc`](https://github.com/apache/spark/commit/08edebc41851a934f70e87b267854b927c58a954).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29961:
URL: https://github.com/apache/spark/pull/29961#discussion_r501204551
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
##########
@@ -581,7 +580,7 @@ class OrcSourceSuite extends OrcSuite with SharedSparkSession {
}
test("Enforce direct encoding column-wise selectively") {
- testSelectiveDictionaryEncoding(isSelective = true)
+ testSelectiveDictionaryEncoding(isSelective = true, isHive23 = false)
Review comment:
This test case is added originally via [[SPARK-25635][SQL][BUILD] Support selective direct encoding in native ORC write](https://github.com/apache/spark/commit/1c9486c1acceb73e5cc6f1fa684b6d992e187a9a) .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29961:
URL: https://github.com/apache/spark/pull/29961#discussion_r501204551
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
##########
@@ -581,7 +580,7 @@ class OrcSourceSuite extends OrcSuite with SharedSparkSession {
}
test("Enforce direct encoding column-wise selectively") {
- testSelectiveDictionaryEncoding(isSelective = true)
+ testSelectiveDictionaryEncoding(isSelective = true, isHive23 = false)
Review comment:
This test case was added originally via [[SPARK-25635][SQL][BUILD] Support selective direct encoding in native ORC write](https://github.com/apache/spark/commit/1c9486c1acceb73e5cc6f1fa684b6d992e187a9a) .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-705256558
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704732996
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34097/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-705130238
**[Test build #129527 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129527/testReport)** for PR 29961 at commit [`071db3b`](https://github.com/apache/spark/commit/071db3b38d8d73362a17a77769018f4b2ba0dea4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704740176
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-705164440
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34132/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-705145800
Thank you, @cloud-fan ! The last commit is renaming only and the compilation passed already in Jenkins.
Merged to master for Apache Spark 3.1.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704875230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-705130238
**[Test build #129527 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129527/testReport)** for PR 29961 at commit [`071db3b`](https://github.com/apache/spark/commit/071db3b38d8d73362a17a77769018f4b2ba0dea4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704740176
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-705040493
Thank you for re-trigger, @HeartSaVioR !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-705164458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29961:
URL: https://github.com/apache/spark/pull/29961#discussion_r501205733
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
##########
@@ -581,7 +580,7 @@ class OrcSourceSuite extends OrcSuite with SharedSparkSession {
}
test("Enforce direct encoding column-wise selectively") {
- testSelectiveDictionaryEncoding(isSelective = true)
+ testSelectiveDictionaryEncoding(isSelective = true, isHive23 = false)
Review comment:
After that, [[SPARK-27402][SQL][TEST-HADOOP3.2][TEST-MAVEN] Fix hadoop-3.2 test issue(except the hive-thriftserver module](https://github.com/apache/spark/commit/f3ddd6f9da27925607c06e55cdfb9a809633238b#diff-c0ffc4377a037f2e6def9779d0ec2527R121
) changed like the following.
```scala
- protected def testSelectiveDictionaryEncoding(isSelective: Boolean) {
+ protected def testSelectiveDictionaryEncoding(isSelective: Boolean, isHive23: Boolean = false) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-705255981
**[Test build #129527 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129527/testReport)** for PR 29961 at commit [`071db3b`](https://github.com/apache/spark/commit/071db3b38d8d73362a17a77769018f4b2ba0dea4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29961:
URL: https://github.com/apache/spark/pull/29961#discussion_r501207044
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
##########
@@ -581,7 +580,7 @@ class OrcSourceSuite extends OrcSuite with SharedSparkSession {
}
test("Enforce direct encoding column-wise selectively") {
- testSelectiveDictionaryEncoding(isSelective = true)
+ testSelectiveDictionaryEncoding(isSelective = true, isHive23 = false)
Review comment:
cc @wangyum and @gatorsmile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704751857
**[Test build #129494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129494/testReport)** for PR 29961 at commit [`08edebc`](https://github.com/apache/spark/commit/08edebc41851a934f70e87b267854b927c58a954).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704739980
**[Test build #129491 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129491/testReport)** for PR 29961 at commit [`08edebc`](https://github.com/apache/spark/commit/08edebc41851a934f70e87b267854b927c58a954).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29961:
URL: https://github.com/apache/spark/pull/29961#discussion_r501206877
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
##########
@@ -581,7 +580,7 @@ class OrcSourceSuite extends OrcSuite with SharedSparkSession {
}
test("Enforce direct encoding column-wise selectively") {
- testSelectiveDictionaryEncoding(isSelective = true)
+ testSelectiveDictionaryEncoding(isSelective = true, isHive23 = false)
Review comment:
Initially, SPARK-27402 seems to use `isHive23` misleadingly because `isHive23=false` means Apache ORC in `sql/core` module and Hive 1.2.1 fork in `sql/hive` module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29961:
URL: https://github.com/apache/spark/pull/29961#discussion_r501202358
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
##########
@@ -581,7 +580,7 @@ class OrcSourceSuite extends OrcSuite with SharedSparkSession {
}
test("Enforce direct encoding column-wise selectively") {
- testSelectiveDictionaryEncoding(isSelective = true)
+ testSelectiveDictionaryEncoding(isSelective = true, isHive23 = false)
Review comment:
This is `sql/core` module. This test case is using Apache ORC directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29961:
URL: https://github.com/apache/spark/pull/29961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704786197
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704786209
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34100/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704733015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-705164458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704774640
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34100/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29961:
URL: https://github.com/apache/spark/pull/29961#discussion_r501173665
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
##########
@@ -581,7 +580,7 @@ class OrcSourceSuite extends OrcSuite with SharedSparkSession {
}
test("Enforce direct encoding column-wise selectively") {
- testSelectiveDictionaryEncoding(isSelective = true)
+ testSelectiveDictionaryEncoding(isSelective = true, isHive23 = false)
Review comment:
why `isHive23` is false here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704786197
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704875230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704786179
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34100/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704750144
retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29961: [SPARK-XXX][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704704721
**[Test build #129491 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129491/testReport)** for PR 29961 at commit [`08edebc`](https://github.com/apache/spark/commit/08edebc41851a934f70e87b267854b927c58a954).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29961:
URL: https://github.com/apache/spark/pull/29961#discussion_r501237611
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
##########
@@ -581,7 +580,7 @@ class OrcSourceSuite extends OrcSuite with SharedSparkSession {
}
test("Enforce direct encoding column-wise selectively") {
- testSelectiveDictionaryEncoding(isSelective = true)
+ testSelectiveDictionaryEncoding(isSelective = true, isHive23 = false)
Review comment:
Sure!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29961:
URL: https://github.com/apache/spark/pull/29961#discussion_r501212199
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
##########
@@ -581,7 +580,7 @@ class OrcSourceSuite extends OrcSuite with SharedSparkSession {
}
test("Enforce direct encoding column-wise selectively") {
- testSelectiveDictionaryEncoding(isSelective = true)
+ testSelectiveDictionaryEncoding(isSelective = true, isHive23 = false)
Review comment:
shall we rename to `isHiveOrc`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-705256558
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704751857
**[Test build #129494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129494/testReport)** for PR 29961 at commit [`08edebc`](https://github.com/apache/spark/commit/08edebc41851a934f70e87b267854b927c58a954).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-705155779
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34132/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704874406
**[Test build #129494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129494/testReport)** for PR 29961 at commit [`08edebc`](https://github.com/apache/spark/commit/08edebc41851a934f70e87b267854b927c58a954).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29961:
URL: https://github.com/apache/spark/pull/29961#issuecomment-704740179
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129491/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org