You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "divijvaidya (via GitHub)" <gi...@apache.org> on 2023/05/10 15:00:30 UTC

[GitHub] [kafka] divijvaidya commented on pull request #13473: KAFKA-14866:Remove controller module metrics when broker is shutting down

divijvaidya commented on PR #13473:
URL: https://github.com/apache/kafka/pull/13473#issuecomment-1542365763

   Hey @hudeqi 
   I had a similar PR merge recently (https://github.com/apache/kafka/pull/13623) and the comments I received in that PR could be applied to this one also.
   Specifically, 
   1. the metric names could be verified individually in the test.
   2. the metric names could be moved in a const and we can use companion object to define those.
   
   Perhaps, you are make those changes in this PR as request the same committer to review this PR as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org