[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9041: [sqllab] Showing schema length only when schema selected

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #9041: [sqllab] Showing schema length only when schema selected
URL: https://github.com/apache/incubator-superset/pull/9041#discussion_r372614198
 
 

 ##########
 File path: superset/assets/src/components/TableSelector.jsx
 ##########
 @@ -370,10 +370,12 @@ export default class TableSelector extends React.PureComponent {
       <div className="section">
         <ControlLabel>
           {t('See table schema')}{' '}
-          <small>
-            ({this.state.tableOptions.length} {t('in')}{' '}
-            <i>{this.props.schema}</i>)
-          </small>
+          {this.props.schema && (
+            <small>
+              ({this.state.tableOptions.length} {t('in')}{' '}
+              <i>{this.props.schema}</i>)
 
 Review comment:
   @etr2460 this is needed for the `(<n> in <schema>)`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org