You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by GitBox <gi...@apache.org> on 2022/11/15 14:39:40 UTC
[GitHub] [tomee] sultan opened a new pull request, #969: [TOMEE-4053] Dependency properties cleanup, step 3 on branch 9.x
sultan opened a new pull request, #969:
URL: https://github.com/apache/tomee/pull/969
this one is about tck tests and microprofile api & impl.
thanks @jeanouii for the wss4j merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [GitHub] [tomee] sultan commented on pull request #969: [TOMEE-4053] Dependency properties cleanup, step 3 on branch 9.x
Posted by Jean-Louis Monteiro <jl...@tomitribe.com>.
Fantastic
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Mon, Jan 30, 2023 at 6:20 PM sultan (via GitHub) <gi...@apache.org> wrote:
>
> sultan commented on PR #969:
> URL: https://github.com/apache/tomee/pull/969#issuecomment-1409017462
>
> not sure the cherry pick will get all the properties in the right
> place. i can do that on 10.x/main later on
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
[GitHub] [tomee] sultan commented on pull request #969: [TOMEE-4053] Dependency properties cleanup, step 3 on branch 9.x
Posted by "sultan (via GitHub)" <gi...@apache.org>.
sultan commented on PR #969:
URL: https://github.com/apache/tomee/pull/969#issuecomment-1409942077
> You are correct, it is for 9.x so the tomee-9.x branch is the one to use. You did great.
>
> Should I cherry pick or try to move it to main (aka TomEE 10.x) or do you plan to do it there as well?
@jeanouii step 3 on branch 10.x here : https://github.com/apache/tomee/pull/997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] sultan commented on pull request #969: [TOMEE-4053] Dependency properties cleanup, step 3 on branch 9.x
Posted by GitBox <gi...@apache.org>.
sultan commented on PR #969:
URL: https://github.com/apache/tomee/pull/969#issuecomment-1371012215
rebased upon tomee-9.x
please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] sultan commented on pull request #969: [TOMEE-4053] Dependency properties cleanup, step 3 on branch 9.x
Posted by "sultan (via GitHub)" <gi...@apache.org>.
sultan commented on PR #969:
URL: https://github.com/apache/tomee/pull/969#issuecomment-1409017462
not sure the cherry pick will get all the properties in the right place. i can do that on 10.x/main later on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] jeanouii commented on pull request #969: [TOMEE-4053] Dependency properties cleanup, step 3 on branch 9.x
Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii commented on PR #969:
URL: https://github.com/apache/tomee/pull/969#issuecomment-1408827398
You are correct, it is for 9.x so the tomee-9.x branch is the one to use. You did great.
Should I cherry pick or try to move it to main (aka TomEE 10.x) or do you plan to do it there as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] jeanouii merged pull request #969: [TOMEE-4053] Dependency properties cleanup, step 3 on branch 9.x
Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii merged PR #969:
URL: https://github.com/apache/tomee/pull/969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] sultan commented on pull request #969: [TOMEE-4053] Dependency properties cleanup, step 3 on branch 9.x
Posted by "sultan (via GitHub)" <gi...@apache.org>.
sultan commented on PR #969:
URL: https://github.com/apache/tomee/pull/969#issuecomment-1407777131
this PR is intended for latest 9.X
should i target main branch or tomee-9.x branch ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org