[GitHub] [jmeter] ham1 commented on a change in pull request #654: Update SSLManager.java

[GitBox <gi...@apache.org>]

ham1 commented on a change in pull request #654:
URL: https://github.com/apache/jmeter/pull/654#discussion_r603632932



##########
File path: src/core/src/main/java/org/apache/jmeter/util/SSLManager.java
##########
@@ -143,7 +143,12 @@ protected synchronized JmeterKeyStore getKeyStore() {
               } else {
                  File initStore = new File(fileName);
                  if (fileName.length() > 0 && initStore.exists()) {
-                     retryLoadKeys(initStore, true);
+                     String os = System.getProperty("os.name");
+                     if ( os.equals("z/OS") ) {

Review comment:
       Is it worth naming the parameter e.g.
   ```
   boolean isZOS = System.getProperty("os.name").equals("z/OS");
   boolean allowEmptyPassword = !isZOS
   retryLoadKeys(initStore, allowEmptyPassword);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org