[GitHub] [netbeans] mbien commented on a diff in pull request #4922: try to figure out why building on 19 fails on gh.

[GitBox <gi...@apache.org>]

mbien commented on code in PR #4922:
URL: https://github.com/apache/netbeans/pull/4922#discussion_r1014730244


##########
.github/workflows/main.yml:
##########
@@ -90,9 +90,15 @@ jobs:
           path: ~/.hgexternalcache
           key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
           restore-keys: ${{ runner.os }}-
+        
+      - name: Setup Gradle properties
+        run: |
+          mkdir -p ~/.gradle
+          echo "org.gradle.java.home=$JAVA_HOME_11_X64" >> ~/.gradle/gradle.properties
+          cat ~/.gradle/gradle.properties

Review Comment:
   build is green.
   
   gradle daemon didn't want to run on JDK 19 (`General error during conversion: Unsupported class file major version 63`)
   
   looks like we can tell the gradle daemon which jdk to use. Similar like with mvnd.
   
   Its interesting to me why this is working locally though. Since I never told it to use any JDK other than the one in JAVA_HOME.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists