You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/03/01 14:58:06 UTC

[GitHub] [incubator-doris] morningman commented on a change in pull request #8282: [Bug] fix string type length limit error && add runtime filter decimal support

morningman commented on a change in pull request #8282:
URL: https://github.com/apache/incubator-doris/pull/8282#discussion_r816845580



##########
File path: be/src/vec/core/block.cpp
##########
@@ -720,12 +720,9 @@ Status Block::serialize(PBlock* pblock, size_t* uncompressed_bytes, size_t* comp
     // serialize data values
     allocated_buf->resize(content_uncompressed_size);
     char* buf = allocated_buf->data();
-    char* start_buf = buf;
     for (const auto& c : *this) {
         buf = c.type->serialize(*(c.column), buf);
     }
-    CHECK(content_uncompressed_size == (buf - start_buf))

Review comment:
       why remove this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org