You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@servicecomb.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/02 14:14:00 UTC
[jira] [Commented] (SCB-850) Support discover instances from
kubernetes cluster
[ https://issues.apache.org/jira/browse/SCB-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601224#comment-16601224 ]
ASF GitHub Bot commented on SCB-850:
------------------------------------
codecov-io commented on issue #433: SCB-850 Support discover instances from kubernetes cluster
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/433#issuecomment-417933739
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433?src=pr&el=h1) Report
> Merging [#433](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/3de5d25f55a9df17b6509dbcd66a8e4c409f9fc8?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `70.01%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
- Coverage 69.23% 69.17% -0.06%
==========================================
Files 139 144 +5
Lines 10768 10965 +197
==========================================
+ Hits 7455 7585 +130
+ Misses 2835 2807 -28
- Partials 478 573 +95
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/log/zap.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433/diff?src=pr&el=tree#diff-cGtnL2xvZy96YXAuZ28=) | `86.91% <ø> (ø)` | :arrow_up: |
| [server/infra/discovery/cache\_kv.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433/diff?src=pr&el=tree#diff-c2VydmVyL2luZnJhL2Rpc2NvdmVyeS9jYWNoZV9rdi5nbw==) | `95.6% <ø> (ø)` | |
| [pkg/log/log\_go19.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dfZ28xOS5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [...ver/plugin/infra/discovery/etcd/listwatch\_inner.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9kaXNjb3ZlcnkvZXRjZC9saXN0d2F0Y2hfaW5uZXIuZ28=) | `100% <ø> (ø)` | |
| [server/plugin/plugin.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wbHVnaW4uZ28=) | `68.68% <0%> (-1.42%)` | :arrow_down: |
| [server/core/core.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvY29yZS5nbw==) | `0% <0%> (ø)` | :arrow_up: |
| [server/core/config.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvY29uZmlnLmdv) | `0% <0%> (ø)` | :arrow_up: |
| [server/core/microservice.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvbWljcm9zZXJ2aWNlLmdv) | `71.23% <0%> (-4.77%)` | :arrow_down: |
| [server/plugin/infra/quota/buildin/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9xdW90YS9idWlsZGluL2NvbW1vbi5nbw==) | `25.39% <0%> (ø)` | :arrow_up: |
| [pkg/gopool/goroutines.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433/diff?src=pr&el=tree#diff-cGtnL2dvcG9vbC9nb3JvdXRpbmVzLmdv) | `100% <100%> (ø)` | :arrow_up: |
| ... and [65 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433?src=pr&el=footer). Last update [3de5d25...1072332](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/433?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Support discover instances from kubernetes cluster
> --------------------------------------------------
>
> Key: SCB-850
> URL: https://issues.apache.org/jira/browse/SCB-850
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Service-Center
> Reporter: little-cui
> Assignee: little-cui
> Priority: Major
> Fix For: service-center-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)