[I] new feature: `ConcurrentLimitLayer` should accept a `Semaphore` [opendal]

["bonsairobo (via GitHub)" <gi...@apache.org>]

bonsairobo opened a new issue, #6591:
URL: https://github.com/apache/opendal/issues/6591

   ### Feature Description
   
   Add a method to `ConcurrentLimitLayer` to provide an `Arc<Semaphore>`.
   
   ### Problem and Solution
   
   Some applications may have their own semaphores used for limiting concurrency. For example, when limiting a process's open file handles. `ConcurrentLimitLayer` is already using `Arc<Semaphore>` internally, so this only needs to be exposed.
   
   ### Additional Context
   
   _No response_
   
   ### Are you willing to contribute to the development of this feature?
   
   - [x] Yes, I am willing to contribute to the development of this feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] new feature: `ConcurrentLimitLayer` should accept a `Semaphore` [opendal]

["PsiACE (via GitHub)" <gi...@apache.org>]

PsiACE closed issue #6591: new feature: `ConcurrentLimitLayer` should accept a `Semaphore`
URL: https://github.com/apache/opendal/issues/6591


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] new feature: `ConcurrentLimitLayer` should accept a `Semaphore` [opendal]

["Xuanwo (via GitHub)" <gi...@apache.org>]

Xuanwo commented on issue #6591:
URL: https://github.com/apache/opendal/issues/6591#issuecomment-3353178938

   We designed this way because we didn’t want to depend on external APIs like Tokio’s Semaphore. But since we have no other choice, let’s just expose it.
   
   Do you want to implement it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] new feature: `ConcurrentLimitLayer` should accept a `Semaphore` [opendal]

["bonsairobo (via GitHub)" <gi...@apache.org>]

bonsairobo commented on issue #6591:
URL: https://github.com/apache/opendal/issues/6591#issuecomment-3353305386

   > We designed this way because we didn’t want to depend on external APIs like Tokio’s Semaphore.
   
   Yea it is kind of a shame that we have to choose one semaphore impl. As such, if users want a different semaphore type, they'll just need to implement their own layer.
   
   > Do you want to implement it?
   
   Sure, though it might not be a high priority for me. If someone else has time to do it, they should preempt me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org