You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gary Gregory <ga...@gmail.com> on 2014/07/28 20:10:38 UTC

Re: [bcel] BCEL 6.0 review

We should change the artifact ID to "commons-bcel" for 6.0 to match up with
the other Commons AIDs.

Gary


On Thu, Jun 5, 2014 at 9:01 AM, Emmanuel Bourg <eb...@apache.org> wrote:

> Hi all,
>
> I'm preparing the 6.0 release for BCEL and I think it's ready for a
> vote. Before I stage the artifacts and start the tag dance could you
> please review the content of this release? If everything is fine I'll
> call for a vote in another thread.
>
> Here are the artifacts and the site I built from the trunk (r1600640):
>
> http://people.apache.org/~ebourg/bcel/
>
> Thank you,
>
> Emmanuel Bourg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [bcel] BCEL 6.0 review

Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Jul 28, 2014 at 2:34 PM, sebb <se...@gmail.com> wrote:

> On 28 July 2014 19:25, Gary Gregory <ga...@gmail.com> wrote:
> > On Mon, Jul 28, 2014 at 2:15 PM, sebb <se...@gmail.com> wrote:
> >
> >> On 28 July 2014 19:10, Gary Gregory <ga...@gmail.com> wrote:
> >> > We should change the artifact ID to "commons-bcel" for 6.0 to match up
> >> with
> >> > the other Commons AIDs.
> >>
> >> In which case we need to change the package name as well.
> >>
> >
> > Hm... I thought it was already "correclty" packaged, but it is not...
>
> Whether the package name is "correct" or not is irrelevant.
>
> There must be a 1-1 correspondance between the Maven pair {group id,
> artifact id} and package name.
> Otherwise Maven can add multiple copies of the jar to the same
> classpath. Jar hell.
>
> > If we are not breaking BC, we should not do that then...
>
> Probably not, as changing packages causes extra work downstream.
>

So: nothing needs to be done. Good to go.

Gary


>
> > Gary
> >
> >
> >> > Gary
> >> >
> >> >
> >> > On Thu, Jun 5, 2014 at 9:01 AM, Emmanuel Bourg <eb...@apache.org>
> >> wrote:
> >> >
> >> >> Hi all,
> >> >>
> >> >> I'm preparing the 6.0 release for BCEL and I think it's ready for a
> >> >> vote. Before I stage the artifacts and start the tag dance could you
> >> >> please review the content of this release? If everything is fine I'll
> >> >> call for a vote in another thread.
> >> >>
> >> >> Here are the artifacts and the site I built from the trunk
> (r1600640):
> >> >>
> >> >> http://people.apache.org/~ebourg/bcel/
> >> >>
> >> >> Thank you,
> >> >>
> >> >> Emmanuel Bourg
> >> >>
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> >> For additional commands, e-mail: dev-help@commons.apache.org
> >> >>
> >> >>
> >> >
> >> >
> >> > --
> >> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> >> > Java Persistence with Hibernate, Second Edition
> >> > <http://www.manning.com/bauer3/>
> >> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> >> > Spring Batch in Action <http://www.manning.com/templier/>
> >> > Blog: http://garygregory.wordpress.com
> >> > Home: http://garygregory.com/
> >> > Tweet! http://twitter.com/GaryGregory
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [bcel] BCEL 6.0 review

Posted by sebb <se...@gmail.com>.
On 29 July 2014 07:17, Bernd Eckenfels <ec...@zusammenkunft.net> wrote:
> hello,
>
> Oh yes of course, that is correct. it will add "multiple copies of the JAR with the same instead of different packages". From this POV it makes sense to enforce new package names.
>
> the wiki page helps to make that clear.
>
> Would be good to have a replacement meta entry in the maven repo which is actually observed by the resolver for such cases.

Not sure what you mean by that.

> greetings
> Bernd
> --
> http://bernd.eckenfels.net
>
> ----- Ursprüngliche Nachricht -----
> Von: "sebb" <se...@gmail.com>
> Gesendet: ‎29.‎07.‎2014 08:03
> An: "Commons Developers List" <de...@commons.apache.org>
> Betreff: Re: [bcel] BCEL 6.0 review
>
> On 29 July 2014 01:59, Bernd Eckenfels <ec...@zusammenkunft.net> wrote:
>> Am Mon, 28 Jul 2014 19:34:05 +0100
>> schrieb sebb <se...@gmail.com>:
>>
>>> There must be a 1-1 correspondance between the Maven pair {group id,
>>> artifact id} and package name.
>>> Otherwise Maven can add multiple copies of the jar to the same
>>> classpath. Jar hell.
>>
>> Uh, why is that?
>>
>> I think the maven version resolving is soley based on
>> coordinates. If you have different versions of a given coordinate it
>> will chose one. If you rename it, it will use both - no matter if it
>> has same package as others or not.
>
> Exactly.
> So Maven needs to be told (via the coords) which jars have the same
> packages and which are different.
>
> See
>
> https://wiki.apache.org/commons/MavenAndClasspath
>
> which is my attempt to explain this further.
>
>> I think only the OSGi/bnd stuff looks at the packages.
>
> And the Java classloader.
>
>> Gruss
>> Bernd
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

AW: [bcel] BCEL 6.0 review

Posted by Bernd Eckenfels <ec...@zusammenkunft.net>.
hello,

Oh yes of course, that is correct. it will add "multiple copies of the JAR with the same instead of different packages". From this POV it makes sense to enforce new package names.

the wiki page helps to make that clear.

Would be good to have a replacement meta entry in the maven repo which is actually observed by the resolver for such cases.

greetings
Bernd
-- 
http://bernd.eckenfels.net

----- Ursprüngliche Nachricht -----
Von: "sebb" <se...@gmail.com>
Gesendet: ‎29.‎07.‎2014 08:03
An: "Commons Developers List" <de...@commons.apache.org>
Betreff: Re: [bcel] BCEL 6.0 review

On 29 July 2014 01:59, Bernd Eckenfels <ec...@zusammenkunft.net> wrote:
> Am Mon, 28 Jul 2014 19:34:05 +0100
> schrieb sebb <se...@gmail.com>:
>
>> There must be a 1-1 correspondance between the Maven pair {group id,
>> artifact id} and package name.
>> Otherwise Maven can add multiple copies of the jar to the same
>> classpath. Jar hell.
>
> Uh, why is that?
>
> I think the maven version resolving is soley based on
> coordinates. If you have different versions of a given coordinate it
> will chose one. If you rename it, it will use both - no matter if it
> has same package as others or not.

Exactly.
So Maven needs to be told (via the coords) which jars have the same
packages and which are different.

See

https://wiki.apache.org/commons/MavenAndClasspath

which is my attempt to explain this further.

> I think only the OSGi/bnd stuff looks at the packages.

And the Java classloader.

> Gruss
> Bernd
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [bcel] BCEL 6.0 review

Posted by sebb <se...@gmail.com>.
On 29 July 2014 01:59, Bernd Eckenfels <ec...@zusammenkunft.net> wrote:
> Am Mon, 28 Jul 2014 19:34:05 +0100
> schrieb sebb <se...@gmail.com>:
>
>> There must be a 1-1 correspondance between the Maven pair {group id,
>> artifact id} and package name.
>> Otherwise Maven can add multiple copies of the jar to the same
>> classpath. Jar hell.
>
> Uh, why is that?
>
> I think the maven version resolving is soley based on
> coordinates. If you have different versions of a given coordinate it
> will chose one. If you rename it, it will use both - no matter if it
> has same package as others or not.

Exactly.
So Maven needs to be told (via the coords) which jars have the same
packages and which are different.

See

https://wiki.apache.org/commons/MavenAndClasspath

which is my attempt to explain this further.

> I think only the OSGi/bnd stuff looks at the packages.

And the Java classloader.

> Gruss
> Bernd
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [bcel] BCEL 6.0 review

Posted by Bernd Eckenfels <ec...@zusammenkunft.net>.
Am Mon, 28 Jul 2014 19:34:05 +0100
schrieb sebb <se...@gmail.com>:

> There must be a 1-1 correspondance between the Maven pair {group id,
> artifact id} and package name.
> Otherwise Maven can add multiple copies of the jar to the same
> classpath. Jar hell.

Uh, why is that?

I think the maven version resolving is soley based on
coordinates. If you have different versions of a given coordinate it
will chose one. If you rename it, it will use both - no matter if it
has same package as others or not.

I think only the OSGi/bnd stuff looks at the packages.

Gruss
Bernd

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [bcel] BCEL 6.0 review

Posted by sebb <se...@gmail.com>.
On 28 July 2014 19:25, Gary Gregory <ga...@gmail.com> wrote:
> On Mon, Jul 28, 2014 at 2:15 PM, sebb <se...@gmail.com> wrote:
>
>> On 28 July 2014 19:10, Gary Gregory <ga...@gmail.com> wrote:
>> > We should change the artifact ID to "commons-bcel" for 6.0 to match up
>> with
>> > the other Commons AIDs.
>>
>> In which case we need to change the package name as well.
>>
>
> Hm... I thought it was already "correclty" packaged, but it is not...

Whether the package name is "correct" or not is irrelevant.

There must be a 1-1 correspondance between the Maven pair {group id,
artifact id} and package name.
Otherwise Maven can add multiple copies of the jar to the same
classpath. Jar hell.

> If we are not breaking BC, we should not do that then...

Probably not, as changing packages causes extra work downstream.

> Gary
>
>
>> > Gary
>> >
>> >
>> > On Thu, Jun 5, 2014 at 9:01 AM, Emmanuel Bourg <eb...@apache.org>
>> wrote:
>> >
>> >> Hi all,
>> >>
>> >> I'm preparing the 6.0 release for BCEL and I think it's ready for a
>> >> vote. Before I stage the artifacts and start the tag dance could you
>> >> please review the content of this release? If everything is fine I'll
>> >> call for a vote in another thread.
>> >>
>> >> Here are the artifacts and the site I built from the trunk (r1600640):
>> >>
>> >> http://people.apache.org/~ebourg/bcel/
>> >>
>> >> Thank you,
>> >>
>> >> Emmanuel Bourg
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> For additional commands, e-mail: dev-help@commons.apache.org
>> >>
>> >>
>> >
>> >
>> > --
>> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> > Java Persistence with Hibernate, Second Edition
>> > <http://www.manning.com/bauer3/>
>> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> > Spring Batch in Action <http://www.manning.com/templier/>
>> > Blog: http://garygregory.wordpress.com
>> > Home: http://garygregory.com/
>> > Tweet! http://twitter.com/GaryGregory
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [bcel] BCEL 6.0 review

Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Jul 28, 2014 at 2:15 PM, sebb <se...@gmail.com> wrote:

> On 28 July 2014 19:10, Gary Gregory <ga...@gmail.com> wrote:
> > We should change the artifact ID to "commons-bcel" for 6.0 to match up
> with
> > the other Commons AIDs.
>
> In which case we need to change the package name as well.
>

Hm... I thought it was already "correclty" packaged, but it is not...

If we are not breaking BC, we should not do that then...

Gary


> > Gary
> >
> >
> > On Thu, Jun 5, 2014 at 9:01 AM, Emmanuel Bourg <eb...@apache.org>
> wrote:
> >
> >> Hi all,
> >>
> >> I'm preparing the 6.0 release for BCEL and I think it's ready for a
> >> vote. Before I stage the artifacts and start the tag dance could you
> >> please review the content of this release? If everything is fine I'll
> >> call for a vote in another thread.
> >>
> >> Here are the artifacts and the site I built from the trunk (r1600640):
> >>
> >> http://people.apache.org/~ebourg/bcel/
> >>
> >> Thank you,
> >>
> >> Emmanuel Bourg
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [bcel] BCEL 6.0 review

Posted by sebb <se...@gmail.com>.
On 28 July 2014 19:10, Gary Gregory <ga...@gmail.com> wrote:
> We should change the artifact ID to "commons-bcel" for 6.0 to match up with
> the other Commons AIDs.

In which case we need to change the package name as well.

> Gary
>
>
> On Thu, Jun 5, 2014 at 9:01 AM, Emmanuel Bourg <eb...@apache.org> wrote:
>
>> Hi all,
>>
>> I'm preparing the 6.0 release for BCEL and I think it's ready for a
>> vote. Before I stage the artifacts and start the tag dance could you
>> please review the content of this release? If everything is fine I'll
>> call for a vote in another thread.
>>
>> Here are the artifacts and the site I built from the trunk (r1600640):
>>
>> http://people.apache.org/~ebourg/bcel/
>>
>> Thank you,
>>
>> Emmanuel Bourg
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org