You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/09/22 22:42:15 UTC

[Impala-ASF-CR] IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19034


Change subject: IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9
......................................................................

IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9

This contains two fixes for issues introduced by
IMPALA-9999's upgrade to GCC 10:
IMPALA-11599: Builds toolchain gdb with the OS compiler,
fixing an issue where it could not run on Centos 7 due
to problems with its RPATH / finding appropriate libstdc++.
IMPALA-11605: Reverts to flatbuffers 1.9, which avoids
a mismatch with the version that Hive uses. This is avoids
classpath incompatibility issues.

Testing:
 - Verified that toolchain gdb works on Centos 7
 - Verified that interoperability with Hive is restored

Change-Id: Ieaafdb1da05cab60b254115faaae55dba8b67dfd
---
M bin/impala-config.sh
M fe/pom.xml
2 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/19034/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieaafdb1da05cab60b254115faaae55dba8b67dfd
Gerrit-Change-Number: 19034
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19034

to look at the new patch set (#2).

Change subject: IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9
......................................................................

IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9

This contains two fixes for issues introduced by
IMPALA-9999's upgrade to GCC 10:
IMPALA-11599: Builds toolchain gdb with the OS compiler,
fixing an issue where it could not run on Centos 7 due
to problems with its RPATH / finding appropriate libstdc++.
IMPALA-11605: Reverts to flatbuffers 1.9, which avoids
a mismatch with the version that Hive uses. This avoids
classpath incompatibility issues.

Testing:
 - Verified that toolchain gdb works on Centos 7
 - Verified that interoperability with Hive is restored

Change-Id: Ieaafdb1da05cab60b254115faaae55dba8b67dfd
---
M bin/impala-config.sh
M fe/pom.xml
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/19034/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieaafdb1da05cab60b254115faaae55dba8b67dfd
Gerrit-Change-Number: 19034
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19034 )

Change subject: IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9
......................................................................

IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9

This contains two fixes for issues introduced by
IMPALA-9999's upgrade to GCC 10:
IMPALA-11599: Builds toolchain gdb with the OS compiler,
fixing an issue where it could not run on Centos 7 due
to problems with its RPATH / finding appropriate libstdc++.
IMPALA-11605: Reverts to flatbuffers 1.9, which avoids
a mismatch with the version that Hive uses. This avoids
classpath incompatibility issues.

Testing:
 - Verified that toolchain gdb works on Centos 7
 - Verified that interoperability with Hive is restored

Change-Id: Ieaafdb1da05cab60b254115faaae55dba8b67dfd
Reviewed-on: http://gerrit.cloudera.org:8080/19034
Tested-by: Joe McDonnell <jo...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
---
M bin/impala-config.sh
M fe/pom.xml
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Joe McDonnell: Verified
  Wenzhe Zhou: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieaafdb1da05cab60b254115faaae55dba8b67dfd
Gerrit-Change-Number: 19034
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19034 )

Change subject: IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8600/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/19034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaafdb1da05cab60b254115faaae55dba8b67dfd
Gerrit-Change-Number: 19034
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Sep 2022 23:34:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19034 )

Change subject: IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11416/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaafdb1da05cab60b254115faaae55dba8b67dfd
Gerrit-Change-Number: 19034
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Sep 2022 23:02:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19034 )

Change subject: IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19034/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19034/1//COMMIT_MSG@15
PS1, Line 15: is avoids
> nit: "avoids" or "is to avoid"
Thanks for pointing that out, fixed



-- 
To view, visit http://gerrit.cloudera.org:8080/19034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaafdb1da05cab60b254115faaae55dba8b67dfd
Gerrit-Change-Number: 19034
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 05:26:36 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19034 )

Change subject: IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaafdb1da05cab60b254115faaae55dba8b67dfd
Gerrit-Change-Number: 19034
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 04:38:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19034 )

Change subject: IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19034/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19034/1//COMMIT_MSG@15
PS1, Line 15: is avoids
nit: "avoids" or "is to avoid"



-- 
To view, visit http://gerrit.cloudera.org:8080/19034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaafdb1da05cab60b254115faaae55dba8b67dfd
Gerrit-Change-Number: 19034
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 02:57:56 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19034 )

Change subject: IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9
......................................................................


Patch Set 2: Verified+1

This is just a commit message change, so I'm carrying the +1 verified


-- 
To view, visit http://gerrit.cloudera.org:8080/19034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaafdb1da05cab60b254115faaae55dba8b67dfd
Gerrit-Change-Number: 19034
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 05:28:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19034 )

Change subject: IMPALA-11599/IMPALA-11605: GCC 10: Fix gdb and change to flatbuffers 1.9
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19034
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaafdb1da05cab60b254115faaae55dba8b67dfd
Gerrit-Change-Number: 19034
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 07:36:38 +0000
Gerrit-HasComments: No