You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "pussuw (via GitHub)" <gi...@apache.org> on 2024/04/19 08:50:17 UTC
[PR] arm64/imx9: Add eDMA driver [nuttx]
pussuw opened a new pull request, #12183:
URL: https://github.com/apache/nuttx/pull/12183
## Summary
This driver supports both eDMA3 and eDMA4 (also referred to as DMA0 / DMA1
in some contexts..)
The IP blocks are almost identical, with sufficiently minor differences
to use them via a unified driver. The price is a great amount of code
obfuscation in the hardware description layer.
Fork-lifted from s32k3xx and adapted for use with two slightly different DMA engines.
## Impact
Adds driver for eDMA3 / eDMA4
## Testing
imx93-evk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm64/imx9: Add eDMA driver [nuttx]
Posted by "pussuw (via GitHub)" <gi...@apache.org>.
pussuw commented on code in PR #12183:
URL: https://github.com/apache/nuttx/pull/12183#discussion_r1573197125
##########
arch/arm64/src/imx9/Kconfig:
##########
@@ -29,10 +29,18 @@ config IMX9_FLEXIO_PWM
menu "i.MX9 Peripheral Selection"
+config IMX9_EDMA
+ bool "eDMA"
+ default n
+ select ARCH_DMA
+
menu "LPUART"
config IMX9_LPUART
bool
+
+config IMX9_UART1
+ bool "UART1"
Review Comment:
Rebase mistake on my behalf, thanks for pointing this out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm64/imx9: Add eDMA driver [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #12183:
URL: https://github.com/apache/nuttx/pull/12183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm64/imx9: Add eDMA driver [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #12183:
URL: https://github.com/apache/nuttx/pull/12183#discussion_r1572618631
##########
arch/arm64/src/imx9/Kconfig:
##########
@@ -29,10 +29,18 @@ config IMX9_FLEXIO_PWM
menu "i.MX9 Peripheral Selection"
+config IMX9_EDMA
+ bool "eDMA"
+ default n
+ select ARCH_DMA
+
menu "LPUART"
config IMX9_LPUART
bool
+
+config IMX9_UART1
+ bool "UART1"
Review Comment:
Does iMX93 has only one UART?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm64/imx9: Add eDMA driver [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #12183:
URL: https://github.com/apache/nuttx/pull/12183#discussion_r1573245191
##########
arch/arm64/include/imx9/chip.h:
##########
@@ -31,6 +31,11 @@
* Pre-processor Definitions
****************************************************************************/
+/* Cache line sizes (in bytes)for the i.MX9 (Cortex-A55) */
+
+#define ARMV8M_DCACHE_LINESIZE 64 /* 64 bytes (16 words) */
Review Comment:
let's change all ARMV8M to ARMV8A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org