Crash on file names containing invalid UTF-8 sequence

[Felix Wiemann <Fe...@gmx.net>]

When there's an unversioned file whose name contains an invalid UTF-8
sequence, Subversion crashes:

$ echo $LC_ALL
en_US.utf8
$ svn st -q
$ touch `echo subversion.äöü | recode utf8..latin1`
$ svn st -q
svn: Valid UTF-8 data
(hex: 73 75 62 76 65 72 73 69 6f 6e 2e)
followed by invalid UTF-8 sequence
(hex: e4 f6 fc)

This is unnecessary because the file is unversioned anyway.
Furthermore, the error message is not particularly helpful.

-- 
For private mail please ensure that the header contains 'Felix Wiemann'.

"the number of contributors [...] is strongly and inversely correlated with the
number of hoops each project makes a contributing user go through."      -- ESR


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Crash on file names containing invalid UTF-8 sequence

[Max Bowsher <ma...@ukf.net>]

Felix Wiemann wrote:
> When there's an unversioned file whose name contains an invalid UTF-8
> sequence, Subversion crashes:

No it doesn't.
It prints an error message, and exits in an orderly and intentional way.

> $ echo $LC_ALL
> en_US.utf8
> $ svn st -q
> $ touch `echo subversion.äöü | recode utf8..latin1`
> $ svn st -q
> svn: Valid UTF-8 data
> (hex: 73 75 62 76 65 72 73 69 6f 6e 2e)
> followed by invalid UTF-8 sequence
> (hex: e4 f6 fc)
>
> This is unnecessary because the file is unversioned anyway.

How do you expect subversion to know whether it is unversioned, without 
resolving its name from bytes to characters?

> Furthermore, the error message is not particularly helpful.

Suggested improvements welcome.

Max.


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org