You are viewing a plain text version of this content. The canonical link for it is here.
Posted to builds@apache.org by Brian Demers <br...@gmail.com> on 2018/07/25 20:18:40 UTC
Setting up Pull-Request job for directory-scimple
Hey!
I'm setting up a PR job for directory-scmiple:
https://builds.apache.org/view/D/view/Directory/job/dir-scimple-pull-requests/
Based on the blog post:
https://blogs.apache.org/infra/entry/github_pull_request_builds_now, and
other jobs I've looked at, it looks like it _should_ be setup correctly.
I've got the *Build pull requests to the repository* and *Enable Git
validated merge support* both checked (and the scm info set to git://
github.com/apache/directory-scimple.git)
Is there anything else obvious I'm missing?
Re: Setting up Pull-Request job for directory-scimple
Posted by Brian Demers <br...@gmail.com>.
Will do!
On Thu, Jul 26, 2018 at 10:20 AM, Lukasz Lenart <lu...@apache.org>
wrote:
> Hm... trying asking infra guys directly via http://infra.chat - maybe
> they have to push a switch ;-)
>
> czw., 26 lip 2018 o 15:59 Brian Demers <br...@gmail.com>
> napisał(a):
> >
> > Thanks for taking a look Lukasz!
> >
> > I added that section, but I'm still not seeing the PRs trigger builds.
> Is
> > there an easy way to check if the webhooks are set up correctly for this
> > repo? (or anything else that I'm missing)
> >
> >
> >
> >
> >
> > On Thu, Jul 26, 2018 at 2:09 AM, Lukasz Lenart <lu...@apache.org>
> > wrote:
> >
> > > śr., 25 lip 2018 o 22:18 Brian Demers <br...@gmail.com>
> napisał(a):
> > > >
> > > > Hey!
> > > >
> > > > I'm setting up a PR job for directory-scmiple:
> > > > https://builds.apache.org/view/D/view/Directory/job/dir-
> > > scimple-pull-requests/
> > > >
> > > > Based on the blog post:
> > > > https://blogs.apache.org/infra/entry/github_pull_request_builds_now,
> and
> > > > other jobs I've looked at, it looks like it _should_ be setup
> correctly.
> > > >
> > > > I've got the *Build pull requests to the repository* and *Enable Git
> > > > validated merge support* both checked (and the scm info set to git://
> > > > github.com/apache/directory-scimple.git)
> > > >
> > > > Is there anything else obvious I'm missing?
> > >
> > > Compering it with our job [1], you are missing "Additional Behaviours
> > > -> Strategy for choosing what to build -> Build commits submitted for
> > > validated merge"
> > > The simplest way is to prepare a small PR to see the job works.
> > >
> > > [1] https://builds.apache.org/view/S-Z/view/Struts/job/
> > > Struts-pull-request-JDK7/configure
> > >
> > >
> > > Regards
> > > --
> > > Łukasz
> > > + 48 606 323 122 http://www.lenart.org.pl/
> > >
>
Re: Setting up Pull-Request job for directory-scimple
Posted by Lukasz Lenart <lu...@apache.org>.
Hm... trying asking infra guys directly via http://infra.chat - maybe
they have to push a switch ;-)
czw., 26 lip 2018 o 15:59 Brian Demers <br...@gmail.com> napisał(a):
>
> Thanks for taking a look Lukasz!
>
> I added that section, but I'm still not seeing the PRs trigger builds. Is
> there an easy way to check if the webhooks are set up correctly for this
> repo? (or anything else that I'm missing)
>
>
>
>
>
> On Thu, Jul 26, 2018 at 2:09 AM, Lukasz Lenart <lu...@apache.org>
> wrote:
>
> > śr., 25 lip 2018 o 22:18 Brian Demers <br...@gmail.com> napisał(a):
> > >
> > > Hey!
> > >
> > > I'm setting up a PR job for directory-scmiple:
> > > https://builds.apache.org/view/D/view/Directory/job/dir-
> > scimple-pull-requests/
> > >
> > > Based on the blog post:
> > > https://blogs.apache.org/infra/entry/github_pull_request_builds_now, and
> > > other jobs I've looked at, it looks like it _should_ be setup correctly.
> > >
> > > I've got the *Build pull requests to the repository* and *Enable Git
> > > validated merge support* both checked (and the scm info set to git://
> > > github.com/apache/directory-scimple.git)
> > >
> > > Is there anything else obvious I'm missing?
> >
> > Compering it with our job [1], you are missing "Additional Behaviours
> > -> Strategy for choosing what to build -> Build commits submitted for
> > validated merge"
> > The simplest way is to prepare a small PR to see the job works.
> >
> > [1] https://builds.apache.org/view/S-Z/view/Struts/job/
> > Struts-pull-request-JDK7/configure
> >
> >
> > Regards
> > --
> > Łukasz
> > + 48 606 323 122 http://www.lenart.org.pl/
> >
Re: Setting up Pull-Request job for directory-scimple
Posted by Brian Demers <br...@gmail.com>.
Thanks for taking a look Lukasz!
I added that section, but I'm still not seeing the PRs trigger builds. Is
there an easy way to check if the webhooks are set up correctly for this
repo? (or anything else that I'm missing)
On Thu, Jul 26, 2018 at 2:09 AM, Lukasz Lenart <lu...@apache.org>
wrote:
> śr., 25 lip 2018 o 22:18 Brian Demers <br...@gmail.com> napisał(a):
> >
> > Hey!
> >
> > I'm setting up a PR job for directory-scmiple:
> > https://builds.apache.org/view/D/view/Directory/job/dir-
> scimple-pull-requests/
> >
> > Based on the blog post:
> > https://blogs.apache.org/infra/entry/github_pull_request_builds_now, and
> > other jobs I've looked at, it looks like it _should_ be setup correctly.
> >
> > I've got the *Build pull requests to the repository* and *Enable Git
> > validated merge support* both checked (and the scm info set to git://
> > github.com/apache/directory-scimple.git)
> >
> > Is there anything else obvious I'm missing?
>
> Compering it with our job [1], you are missing "Additional Behaviours
> -> Strategy for choosing what to build -> Build commits submitted for
> validated merge"
> The simplest way is to prepare a small PR to see the job works.
>
> [1] https://builds.apache.org/view/S-Z/view/Struts/job/
> Struts-pull-request-JDK7/configure
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
Re: Setting up Pull-Request job for directory-scimple
Posted by Lukasz Lenart <lu...@apache.org>.
śr., 25 lip 2018 o 22:18 Brian Demers <br...@gmail.com> napisał(a):
>
> Hey!
>
> I'm setting up a PR job for directory-scmiple:
> https://builds.apache.org/view/D/view/Directory/job/dir-scimple-pull-requests/
>
> Based on the blog post:
> https://blogs.apache.org/infra/entry/github_pull_request_builds_now, and
> other jobs I've looked at, it looks like it _should_ be setup correctly.
>
> I've got the *Build pull requests to the repository* and *Enable Git
> validated merge support* both checked (and the scm info set to git://
> github.com/apache/directory-scimple.git)
>
> Is there anything else obvious I'm missing?
Compering it with our job [1], you are missing "Additional Behaviours
-> Strategy for choosing what to build -> Build commits submitted for
validated merge"
The simplest way is to prepare a small PR to see the job works.
[1] https://builds.apache.org/view/S-Z/view/Struts/job/Struts-pull-request-JDK7/configure
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/