You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/08/26 12:41:44 UTC
[GitHub] [ozone] Xushaohong opened a new pull request #2586: HDDS-5680. Fix bug for incomplete SCM ratis log
Xushaohong opened a new pull request #2586:
URL: https://github.com/apache/ozone/pull/2586
## What changes were proposed in this pull request?
change the place where the RatisMetricReporters registers
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5680
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
CI
right now the metrics all appears
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2586: HDDS-5680. Fix bug for incomplete SCM ratis metrics
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2586:
URL: https://github.com/apache/ozone/pull/2586#issuecomment-908874697
LGTM, + 1.
Thanks @bshashikant for the code review and @Xushaohong for the contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong closed pull request #2586: HDDS-5680. Fix bug for incomplete SCM ratis log
Posted by GitBox <gi...@apache.org>.
Xushaohong closed pull request #2586:
URL: https://github.com/apache/ozone/pull/2586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2586: HDDS-5680. Fix bug for incomplete SCM ratis metrics
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2586:
URL: https://github.com/apache/ozone/pull/2586#issuecomment-908874697
LGTM, + 1.
Thanks @bshashikant for the code review and @Xushaohong for the contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on pull request #2586: HDDS-5680. Fix bug for incomplete SCM ratis log
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #2586:
URL: https://github.com/apache/ozone/pull/2586#issuecomment-906935352
@Xushaohong , can you please explain the issue in bit detail here. What do you mean by incomplete ratis log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi merged pull request #2586: HDDS-5680. Fix bug for incomplete SCM ratis metrics
Posted by GitBox <gi...@apache.org>.
ChenSammi merged pull request #2586:
URL: https://github.com/apache/ozone/pull/2586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong edited a comment on pull request #2586: HDDS-5680. Fix bug for incomplete SCM ratis log
Posted by GitBox <gi...@apache.org>.
Xushaohong edited a comment on pull request #2586:
URL: https://github.com/apache/ozone/pull/2586#issuecomment-906943662
> @Xushaohong , can you please explain the issue in bit detail here. What do you mean by incomplete ratis log?
@bshashikant
Before the PR HDDS-5640, we don't have any ratis metrics for SCM, but we do have for OM and DN. I updated it for SCM in HDDS-5640, but my colleague found that the metrics from HTTP /prom is incomplete, some metrics didn't show on Prometheus Page. The reason for it is due to the registration action should be done before the ratis server is initialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong commented on pull request #2586: HDDS-5680. Fix bug for incomplete SCM ratis log
Posted by GitBox <gi...@apache.org>.
Xushaohong commented on pull request #2586:
URL: https://github.com/apache/ozone/pull/2586#issuecomment-906943662
> @Xushaohong , can you please explain the issue in bit detail here. What do you mean by incomplete ratis log?
Before the PR HDDS-5640, we don't have any ratis metrics for SCM, but we do have for OM and DN. I updated it for SCM in HDDS-5640, but my colleague found that the metrics from HTTP /prom is incomplete, some metrics didn't show on Prometheus Page. The reason for it is due to the registration action should be done before the ratis server is initialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi merged pull request #2586: HDDS-5680. Fix bug for incomplete SCM ratis metrics
Posted by GitBox <gi...@apache.org>.
ChenSammi merged pull request #2586:
URL: https://github.com/apache/ozone/pull/2586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong closed pull request #2586: HDDS-5680. Fix bug for incomplete SCM ratis log
Posted by GitBox <gi...@apache.org>.
Xushaohong closed pull request #2586:
URL: https://github.com/apache/ozone/pull/2586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org