You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@crail.apache.org by PepperJo <gi...@git.apache.org> on 2018/03/28 20:57:58 UTC
[GitHub] incubator-crail pull request #13: Checkstyle plugin with google style
GitHub user PepperJo opened a pull request:
https://github.com/apache/incubator-crail/pull/13
Checkstyle plugin with google style
Add checkstyle plugin but do not check on compilation yet.
Checkstyle can be run with 'mvn checkstyle:check'
https://issues.apache.org/jira/projects/CRAIL/issues/CRAIL-19
Signed-off-by: Jonas Pfefferle <pe...@apache.org>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PepperJo/incubator-crail codestyle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-crail/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit 436fcc384a053407c5f96862e0b192d3cd44093f
Author: Jonas Pfefferle <pe...@...>
Date: 2018-03-28T20:54:19Z
Checkstyle plugin with google style
Add checkstyle plugin but do not check on compilation yet.
Checkstyle can be run with 'mvn checkstyle:check'
https://issues.apache.org/jira/projects/CRAIL/issues/CRAIL-19
Signed-off-by: Jonas Pfefferle <pe...@apache.org>
----
---
[GitHub] incubator-crail issue #13: Checkstyle plugin with google style
Posted by animeshtrivedi <gi...@git.apache.org>.
Github user animeshtrivedi commented on the issue:
https://github.com/apache/incubator-crail/pull/13
Lets merge this. Also I think, having something like this would be useful for DaRPC and DiSNI as well?
---
[GitHub] incubator-crail issue #13: Checkstyle plugin with google style
Posted by PepperJo <gi...@git.apache.org>.
Github user PepperJo commented on the issue:
https://github.com/apache/incubator-crail/pull/13
Renamed file.
---
[GitHub] incubator-crail issue #13: Checkstyle plugin with google style
Posted by patrickstuedi <gi...@git.apache.org>.
Github user patrickstuedi commented on the issue:
https://github.com/apache/incubator-crail/pull/13
Looks good. Can we just rename google_check.xml to checkstyle.xml?
---
[GitHub] incubator-crail issue #13: Checkstyle plugin with google style
Posted by PepperJo <gi...@git.apache.org>.
Github user PepperJo commented on the issue:
https://github.com/apache/incubator-crail/pull/13
Let me try again last time I checked it did not work as expected.
---
[GitHub] incubator-crail issue #13: Checkstyle plugin with google style
Posted by patrickstuedi <gi...@git.apache.org>.
Github user patrickstuedi commented on the issue:
https://github.com/apache/incubator-crail/pull/13
Why not add the checkstyle plugin to the top level pom?
---
[GitHub] incubator-crail pull request #13: Checkstyle plugin with google style
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-crail/pull/13
---
[GitHub] incubator-crail issue #13: Checkstyle plugin with google style
Posted by PepperJo <gi...@git.apache.org>.
Github user PepperJo commented on the issue:
https://github.com/apache/incubator-crail/pull/13
sure
---
[GitHub] incubator-crail issue #13: Checkstyle plugin with google style
Posted by PepperJo <gi...@git.apache.org>.
Github user PepperJo commented on the issue:
https://github.com/apache/incubator-crail/pull/13
Moved plugin to parent pom. Note that I do not yet enforce style check on compilation but you can manually run checkstyle with 'mvn checkstyle:check'. I propose whenever someone changes a file to make two commits one that fixes the style and one for the issue. Otherwise solving all the errors would probably take a few hours...
---
[GitHub] incubator-crail issue #13: Checkstyle plugin with google style
Posted by PepperJo <gi...@git.apache.org>.
Github user PepperJo commented on the issue:
https://github.com/apache/incubator-crail/pull/13
Also if someone is not happy with the suggestions of the style checker please make a pull request to change the google style derived xml file.
---