You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/31 23:24:26 UTC

[GitHub] [incubator-gobblin] arjun4084346 commented on a change in pull request #2945: [GOBBLIN-1105] some refactoring and make MysqlJobStatusStateStore implements DatasetStateStore

arjun4084346 commented on a change in pull request #2945: [GOBBLIN-1105] some refactoring and make MysqlJobStatusStateStore implements DatasetStateStore
URL: https://github.com/apache/incubator-gobblin/pull/2945#discussion_r401271572
 
 

 ##########
 File path: gobblin-metastore/src/main/java/org/apache/gobblin/metastore/MysqlJobStatusStateStore.java
 ##########
 @@ -33,7 +33,7 @@
  *
  * @param <T> state object type
  **/
-public class MysqlJobStatusStateStore<T extends State> extends MysqlStateStore {
+public class MysqlJobStatusStateStore<T extends State> extends MysqlStateStore implements DatasetStateStore {
 
 Review comment:
   Not easily.
   MysqlDatasetStateStore implements DatasetStateStore<JobState.DatasetState>
   we want MysqlDatasetStateStore to implement DatasetStateStore<State>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services