You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2021/11/04 21:58:11 UTC

[Impala-ASF-CR] WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala

Wenzhe Zhou has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17948 )

Change subject: WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala
......................................................................

WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala

There are some API changes in the new version of protobuf library.
This patch makes necessary changes for Impala code to pass compiling.
It also adds a work around for the static initializer issue, which
is caused by the conflicts between two copies of protobuf library
in impalad's binary, one came from Kudu client shared library.

Testing:
 - Passed core DEBUG build and exhaustive DEBUG build.
 - TODO pass a core ASAN build

Change-Id: Ia1df4faceff9fda169c9d15fe8b1e69cfabe0d43
---
M be/src/kudu/rpc/exactly_once_rpc-test.cc
M be/src/kudu/rpc/inbound_call.cc
M be/src/kudu/rpc/outbound_call.cc
M be/src/kudu/rpc/result_tracker.h
M be/src/kudu/rpc/serialization.cc
M be/src/kudu/rpc/serialization.h
M be/src/kudu/util/pb_util.cc
M be/src/kudu/util/protobuf_util.h
M be/src/rpc/rpc-mgr.cc
M bin/impala-config.sh
10 files changed, 113 insertions(+), 49 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/17948/4
-- 
To view, visit http://gerrit.cloudera.org:8080/17948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1df4faceff9fda169c9d15fe8b1e69cfabe0d43
Gerrit-Change-Number: 17948
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>