[GitHub] coheigea commented on a change in pull request #456: CXF-7867 - Allow the AbstractSpnegoAuthSupplier loginConfig to be used

[GitBox <gi...@apache.org>]

coheigea commented on a change in pull request #456: CXF-7867 - Allow the AbstractSpnegoAuthSupplier loginConfig to be used
URL: https://github.com/apache/cxf/pull/456#discussion_r224367767
 
 

 ##########
 File path: rt/transports/http/src/main/java/org/apache/cxf/transport/http/auth/AbstractSpnegoAuthSupplier.java
 ##########
 @@ -120,6 +120,10 @@ public String getAuthorization(AuthorizationPolicy authPolicy,
                 lc.login();
                 subject = lc.getSubject();
             }
+        } else if (loginConfig != null) {
+            LoginContext lc = new LoginContext("", new Subject(), null, loginConfig);
 
 Review comment:
   Do we need "new Subject()" here or does null work instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services