You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/12/30 09:13:04 UTC

[GitHub] [zookeeper] wordfeng opened a new pull request #1195: fix zkCli.cmd error

wordfeng opened a new pull request #1195: fix zkCli.cmd error
URL: https://github.com/apache/zookeeper/pull/1195
 
 
   line 20 lost set, it caused this error in this picture when i run zkServer.cmd.
   ![image](https://user-images.githubusercontent.com/25249417/71575227-2b654f00-2b27-11ea-9219-4dde54537015.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] maoling commented on a change in pull request #1195: fix zkCli.cmd error

Posted by GitBox <gi...@apache.org>.
maoling commented on a change in pull request #1195: fix zkCli.cmd error
URL: https://github.com/apache/zookeeper/pull/1195#discussion_r362412744
 
 

 ##########
 File path: bin/zkCli.cmd
 ##########
 @@ -17,7 +17,7 @@ REM limitations under the License.
 setlocal
 call "%~dp0zkEnv.cmd"
 
-ZOO_LOG_FILE=zookeeper-%USERNAME%-cli-%COMPUTERNAME%.log
+set ZOO_LOG_FILE=zookeeper-%USERNAME%-cli-%COMPUTERNAME%.log
 
 set ZOOMAIN=org.apache.zookeeper.ZooKeeperMain
 
 Review comment:
   @wordfeng
   - Yes, this bug has been fixed by [ZOOKEEPER-3453](https://issues.apache.org/jira/browse/ZOOKEEPER-3453)
   - Please change this github description to "`ZOOKEEPER-3453: missing 'SET' in zkCli on windows`"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] maoling commented on issue #1195: ZOOKEEPER-3453: missing 'SET' in zkCli on windows

Posted by GitBox <gi...@apache.org>.
maoling commented on issue #1195: ZOOKEEPER-3453: missing 'SET' in zkCli on windows
URL: https://github.com/apache/zookeeper/pull/1195#issuecomment-578025961
 
 
   @wordfeng 
    ZooKeeper 3.5.6 which you want to push has already been released. Would you please create another PR for the `branch-3.5` branch and close this PR?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] wordfeng closed pull request #1195: ZOOKEEPER-3453: missing 'SET' in zkCli on windows

Posted by GitBox <gi...@apache.org>.
wordfeng closed pull request #1195: ZOOKEEPER-3453: missing 'SET' in zkCli on windows
URL: https://github.com/apache/zookeeper/pull/1195
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] wordfeng commented on a change in pull request #1195: ZOOKEEPER-3453: missing 'SET' in zkCli on windows

Posted by GitBox <gi...@apache.org>.
wordfeng commented on a change in pull request #1195: ZOOKEEPER-3453: missing 'SET' in zkCli on windows
URL: https://github.com/apache/zookeeper/pull/1195#discussion_r362416658
 
 

 ##########
 File path: bin/zkCli.cmd
 ##########
 @@ -17,7 +17,7 @@ REM limitations under the License.
 setlocal
 call "%~dp0zkEnv.cmd"
 
-ZOO_LOG_FILE=zookeeper-%USERNAME%-cli-%COMPUTERNAME%.log
+set ZOO_LOG_FILE=zookeeper-%USERNAME%-cli-%COMPUTERNAME%.log
 
 set ZOOMAIN=org.apache.zookeeper.ZooKeeperMain
 
 Review comment:
   ok, i changed it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli commented on issue #1195: ZOOKEEPER-3453: missing 'SET' in zkCli on windows

Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1195: ZOOKEEPER-3453: missing 'SET' in zkCli on windows
URL: https://github.com/apache/zookeeper/pull/1195#issuecomment-570178506
 
 
   @maoling is this change worth to be ported to branch-3.6?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] maoling commented on issue #1195: ZOOKEEPER-3453: missing 'SET' in zkCli on windows

Posted by GitBox <gi...@apache.org>.
maoling commented on issue #1195: ZOOKEEPER-3453: missing 'SET' in zkCli on windows
URL: https://github.com/apache/zookeeper/pull/1195#issuecomment-570184180
 
 
   @eolivelli 
   branch-3.6 and master have fixed this bug, only branch-3.5.x needs this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] wordfeng commented on issue #1195: ZOOKEEPER-3453: missing 'SET' in zkCli on windows

Posted by GitBox <gi...@apache.org>.
wordfeng commented on issue #1195: ZOOKEEPER-3453: missing 'SET' in zkCli on windows
URL: https://github.com/apache/zookeeper/pull/1195#issuecomment-578080428
 
 
   OK

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services